Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for successful base station updates to websocket #892

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

bachya
Copy link
Owner

@bachya bachya commented Sep 10, 2024

Describe what the PR does:

N/A

Does this fix a specific issue?

Fixes #891

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Sep 10, 2024
@bachya bachya self-assigned this Sep 10, 2024
Copy link

codeclimate bot commented Sep 10, 2024

Code Climate has analyzed commit ddfef8c and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (347d7f8) to head (ddfef8c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #892   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1017      1018    +1     
=========================================
+ Hits          1017      1018    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bachya bachya merged commit b42a3a0 into dev Sep 10, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown Websocket Event Base Station Update Succeeded
1 participant