Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address upcoming deprecation of datetime.datetime.utcnow() #719

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Conversation

bachya
Copy link
Owner

@bachya bachya commented Jan 12, 2024

Describe what the PR does:

SSIA

Does this fix a specific issue?

Fixes #718

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Jan 12, 2024
@bachya bachya self-assigned this Jan 12, 2024
Copy link

codeclimate bot commented Jan 13, 2024

Code Climate has analyzed commit 9ae2560 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33b5722) 100.00% compared to head (9ae2560) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #719   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          988       994    +6     
=========================================
+ Hits           988       994    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bachya bachya merged commit 9aeb778 into dev Jan 13, 2024
12 checks passed
@bachya bachya deleted the datetimes branch January 13, 2024 00:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings when running poetry run pytest --cov simplipy tests
1 participant