Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on pytz #619

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Remove dependency on pytz #619

merged 5 commits into from
Sep 18, 2023

Conversation

scop
Copy link

@scop scop commented Sep 17, 2023

Describe what the PR does:

Removes dependency on pytz.

Does this fix a specific issue?

Some background in https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

simplipy/util/dt.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #619 (f984d4b) into dev (4034fb9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #619   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          990       988    -2     
=========================================
- Hits           990       988    -2     
Files Changed Coverage Δ
simplipy/util/dt.py 100.00% <100.00%> (ø)

@codeclimate
Copy link

codeclimate bot commented Sep 18, 2023

Code Climate has analyzed commit f984d4b and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bachya bachya added the dependencies Upgrade or downgrade of project dependencies label Sep 18, 2023
@bachya bachya merged commit a5ac1f0 into bachya:dev Sep 18, 2023
9 checks passed
@scop scop deleted the refactor/pytz-dep branch September 18, 2023 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants