-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to expose camera and doorbell data #182
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #182 +/- ##
=======================================
Coverage ? 100.00%
=======================================
Files ? 12
Lines ? 634
Branches ? 0
=======================================
Hits ? 634
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
@bachya would you mind taking a look? This is some of the spinoff work from home-assistant/core#40129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also look at the Sourcery refactoring and incorporate its requests (if you feel they're spurious or unnecessary, let's talk).
Also, this PR needs to be linked to #85 (assuming it either (a) fixes it or (b) makes progress against it).
@bachya thanks for the feedback, I addressed all your points. Let me know if there's anything else you need here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, I think!
31188c1
to
aba2e92
Compare
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.39%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Code Climate has analyzed commit a0c2392 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Describe what the PR does:
Adds support to expose camera and doorbell data
Does this fix a specific issue?
References #85
Checklist:
README.md
anddocs/
with any new documentation.AUTHORS.md
.