Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ecowitt HP2561 to device mapping #884

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add Ecowitt HP2561 to device mapping #884

merged 1 commit into from
Feb 6, 2024

Conversation

dezmui
Copy link
Contributor

@dezmui dezmui commented Feb 6, 2024

Describe what the PR does:

Adds a new device (HP2561) to the mapping

Does this fix a specific issue?

Fixes #883

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb8d4b5) 100.00% compared to head (db3ea4f) 100.00%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #884   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         1735      1735           
=========================================
  Hits          1735      1735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bachya bachya merged commit e564eb1 into bachya:dev Feb 6, 2024
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HP2564 as a known device
2 participants