Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make boolean config validator more efficient #855

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Make boolean config validator more efficient #855

merged 2 commits into from
Jan 18, 2024

Conversation

bachya
Copy link
Owner

@bachya bachya commented Jan 18, 2024

Describe what the PR does:

  • Don’t recalculate what strings are truthy/falsey every time the validator is called.
  • Use sets for slightly faster inclusion checks.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the maintenance Generic library tasks label Jan 18, 2024
@bachya bachya self-assigned this Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aad471) 100.00% compared to head (1541749) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #855   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         1734      1736    +2     
=========================================
+ Hits          1734      1736    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bachya bachya merged commit fcd0af1 into dev Jan 18, 2024
12 checks passed
@bachya bachya deleted the boolean branch January 19, 2024 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Generic library tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant