Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unit system constants with an Enum #848

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Replace unit system constants with an Enum #848

merged 2 commits into from
Jan 18, 2024

Conversation

bachya
Copy link
Owner

@bachya bachya commented Jan 18, 2024

Describe what the PR does:

This allows us the ability to type things more strictly.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the maintenance Generic library tasks label Jan 18, 2024
@bachya bachya self-assigned this Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5405382) 100.00% compared to head (84ea6a9) 100.00%.

❗ Current head 84ea6a9 differs from pull request most recent head f0d08db. Consider uploading reports for the commit f0d08db to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #848   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1763      1764    +1     
=========================================
+ Hits          1763      1764    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bachya bachya merged commit 00dcb66 into dev Jan 18, 2024
9 checks passed
@bachya bachya deleted the unit-enum branch January 18, 2024 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Generic library tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant