Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data detection for heap sensor #845

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Add data detection for heap sensor #845

merged 2 commits into from
Jan 17, 2024

Conversation

bachya
Copy link
Owner

@bachya bachya commented Jan 17, 2024

Describe what the PR does:

SSIA. Ecowitt devices with upgradable firmware are starting to roll this data point out.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Jan 17, 2024
@bachya bachya self-assigned this Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b80fb7) 100.00% compared to head (3ab6e63) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #845   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        32    +1     
  Lines         1759      1769   +10     
=========================================
+ Hits          1759      1769   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bachya bachya merged commit 66b0299 into dev Jan 17, 2024
12 checks passed
@bachya bachya deleted the heap branch January 17, 2024 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant