Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only publish MQTT Discovery payload when config changes #749

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

bachya
Copy link
Owner

@bachya bachya commented Oct 29, 2023

Describe what the PR does:

We published an MQTT Discovery payload with every state change, which flooded logs.

Does this fix a specific issue?

Fixes #704

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Oct 29, 2023
@bachya bachya self-assigned this Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #749 (91e115b) into dev (0694a63) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #749   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1734      1766   +32     
=========================================
+ Hits          1734      1766   +32     
Files Coverage Δ
ecowitt2mqtt/helpers/publisher/mqtt/hass.py 100.00% <100.00%> (ø)

@bachya bachya merged commit 073d6a7 into dev Oct 29, 2023
11 checks passed
@bachya bachya deleted the fix-too-many-discovery-payloads branch October 29, 2023 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update of sensor entities also floods HA mqtt discovery
1 participant