Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fix testcase stdout and add trace property #38

Merged

Conversation

b4nst
Copy link
Contributor

@b4nst b4nst commented Nov 27, 2023

I think #12 was actually a misread of the schema and has been merged too fast. In my understanding system-out and system-err are separated from the error or failure cause.

From the [schema] mentioned in #12:

Contains as a text node relevant data for the error, e.g., a stack trace

stack trace != stdout + stderr (even if they can be sometime related, by being a subset for example).

This PR revert the system-out and system-err, and add an additional property to error and failure types. I did not want to break the API so I introduced set_trace on TestCaseBuilder which ignore non erroneous results.

@bachp
Copy link
Owner

bachp commented Dec 7, 2023

If I understand correctly this change introduces a proper cause for each case. Making system-err and system-out their own fields.

If this is correct and from looking at the schema this change makes sense to me.

@bachp bachp merged commit 14883cd into bachp:master Dec 7, 2023
4 checks passed
@b4nst b4nst deleted the feat/fix-testcase-stdout-and-add-trace-property branch December 7, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants