chore: Remove nolint:errcheck and instead handle errors #134
+32
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
requested review from
gitferry and
RafilxTenfen
and removed request for
a team
gitferry
approved these changes
Oct 7, 2024
| err := types.RegisterQueryHandlerClient(context.Background(), mux, types.NewQueryClient(clientCtx)) | ||
| if err != nil { | ||
| panic(err) | ||
| if err := types.RegisterQueryHandlerClient(context.Background(), mux, types.NewQueryClient(clientCtx)); err != nil { |
There was a problem hiding this comment.
thought to keep it consistent with the other ones, this was the only instance that previously panicked. Should we panic on every one of them or just return? Osmosis seems to do the latter, so I followed their approach, but happy to change it if people think the other way is better.
Lazar955
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are adding static analyzers in the codebase, many of them will point out unhandled errors. If we add annotations to our codebase for each of them, this might bloat the codebase. Another approach is to only allow a single static analyzer fail about unhandled errors, while ignoring the rest.
In this PR, I opted to just handle the errors in a vanilla way to remove the
nolint:errcheckfrom the annotations. The way the errors are handled fortypes.RegisterQueryHandlerClientwas inspired by osmosis. Note though that Osmosis usesnolint:errcheckas well for the same function in other places.