Use CodeMirror 6 in REPL #3014
Open
Use CodeMirror 6 in REPL #3014
+163
−192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for babel-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JLHwung
commented
Nov 15, 2024
|
|
||
| type Props = { | ||
| autoFocus: boolean; |
There was a problem hiding this comment.
The autoFocus prop is removed because we are not using this prop.
✅ Deploy Preview for babel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JLHwung
commented
Nov 15, 2024
JLHwung
commented
Nov 15, 2024
| } | ||
|
|
||
| injectGlobal({ | ||
| ".CodeMirror": { | ||
| height: "100% !important", | ||
| width: "100% !important", | ||
| WebkitOverflowScrolling: "touch", |
There was a problem hiding this comment.
This CSS property is long obsolete.
JLHwung
commented
Nov 15, 2024
| @@ -30,7 +33,7 @@ export default function CodeMirrorPanel(props: Props) { | |||
| <CodeMirror | |||
| onChange={onChange} | |||
| options={{ | |||
| ...props.options, | |||
There was a problem hiding this comment.
The fileSize option is not used by the codemirror component. So here we explicitly specify the passing-through options.
JLHwung
force-pushed
the
bump-repl-code-mirror
branch
from
6d59fea
to
9434c05
Compare
The CodeMirror component will be rendered directly within the parentRef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we migrate the CodeMirror from 5 to 6 for REPL.
New features from this upgrade:
This is a vast rewrite of the
CodeMirrorbridging React component. Here are the UI tests I have performed manually:preserveScrollPosition: Input a 300-line text, scroll the output to the bottom, change the input, the output should preserve the scroll positionlineWrapping: Input a 300-column text, toggle the "Line Wrap" option, the input should apply softwrapreadOnly: The output editor should be readonlyPreview link: https://deploy-preview-3014--babel.netlify.app/repl