fix: REPL with preset-env in Babel 8
#2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for babel-next pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for babel ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
JLHwung
approved these changes
Sep 26, 2024
js/repl/PluginConfig.ts
Outdated
| @@ -66,7 +66,7 @@ const envPresetDefaults = { | |||
| default: "3.21", | |||
| }, | |||
| modules: { | |||
| default: false, | |||
| default: "false", | |||
There was a problem hiding this comment.
Q: Why is this a string?
There was a problem hiding this comment.
select.value does not accept false.
Thanks for your reminder, I checked the code and it handles the false of string.
There was a problem hiding this comment.
No, it seems like it should be done another way. :)
JLHwung
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2969