Introduce Feature flags as a concept #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one might feel odd. Well, it just felt odd to me that the function would be called and then just return `nil` if the feature flag was deactivated. I felt the function shouldn't be called at all. This way, for instance, if it was deactivated in the test environment we could still test it etc - the behavior is still there. That's all debatable and more of a "I feel like this" kind of thing.
PragTob
commented
Nov 30, 2024
PragTob
commented
Nov 30, 2024
PragTob
force-pushed
the
feature-flags
branch
from
db4b66a to
8f8b008
Compare
|
nice, improves readability a lot |
|
I would propose to split the other 2 thoughts in respective issues. I haven't understood 100% the first one, second point sounds like a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #480
Other thinking:
optionskey seemingly has feature flags and some full on options mixed with each other, instead of pre-fixing keysfeature(and one post-fixed enabled) I think I'd put them into a sub-key (of options)feature_flags: [_flags_]but I don't know if we need to keep backwards compatibility here (not change the names, do people adjust this themselves or do they go via system envs?)feature_brainstorming_removal_after_daysand holds a number of days, not a boolean - maybe we want to have this implementation as a more generalOptionsmodule that then also has a function likegetthat just gets that option value? I'm unsure and would need input!