hide sorting buttons for other users

lib/mindwendel_web/live/brainstorming_live/show.ex

@@ -119,14 +119,24 @@ defmodule MindwendelWeb.BrainstormingLive.Show do
 
   @impl true
   def handle_event("sort_by_likes", %{"id" => id}, socket) do
-    Ideas.update_ideas_for_brainstorming_by_likes(id)
-    Brainstormings.broadcast({:ok, Brainstormings.get_brainstorming!(id)}, :brainstorming_updated)
+    brainstorming = Brainstormings.get_brainstorming!(id)
+
+    if has_move_permission(brainstorming, socket.assigns.current_user) do
+      Ideas.update_ideas_for_brainstorming_by_likes(id)
+      Brainstormings.broadcast({:ok, brainstorming}, :brainstorming_updated)
+    end
+
     {:noreply, socket}
   end
 
   def handle_event("sort_by_label", %{"id" => id}, socket) do
-    Ideas.update_ideas_for_brainstorming_by_labels(id)
-    Brainstormings.broadcast({:ok, Brainstormings.get_brainstorming!(id)}, :brainstorming_updated)
+    brainstorming = Brainstormings.get_brainstorming!(id)
+
+    if has_move_permission(brainstorming, socket.assigns.current_user) do
+      Ideas.update_ideas_for_brainstorming_by_labels(id)
+      Brainstormings.broadcast({:ok, brainstorming}, :brainstorming_updated)
+    end
+
     {:noreply, socket}
   end
 

lib/mindwendel_web/live/brainstorming_live/show.html.heex

@@ -27,11 +27,13 @@
         class: "btn btn-primary m-1 d-none d-md-block",
         title: gettext("New idea page (Hotkey: i)")
       ) %>
-      <%= link to: "#", class: "btn btn-primary m-1", phx_click: "sort_by_likes", phx_value_id: @brainstorming.id, title: gettext("Sort by likes") do %>
-        <i class="bi-sort-numeric-up-alt"></i> <%= gettext("Likes") %>
-      <% end %>
-      <%= link to: "#", class: "btn btn-primary m-1", phx_click: "sort_by_label", phx_value_id: @brainstorming.id, title: gettext("Sort by label") do %>
-        <i class="bi-sort-alpha-up-alt"></i> <%= gettext("Label") %>
+      <%= if has_move_permission(@brainstorming, @current_user) do %>
+        <%= link to: "#", class: "btn btn-primary m-1", phx_click: "sort_by_likes", phx_value_id: @brainstorming.id, title: gettext("Sort by likes") do %>
+          <i class="bi-sort-numeric-up-alt"></i> <%= gettext("Likes") %>
+        <% end %>
+        <%= link to: "#", class: "btn btn-primary m-1", phx_click: "sort_by_label", phx_value_id: @brainstorming.id, title: gettext("Sort by label") do %>
+          <i class="bi-sort-alpha-up-alt"></i> <%= gettext("Label") %>
+        <% end %>
       <% end %>
 
       <%= live_patch to: Routes.brainstorming_show_path(@socket, :share, @brainstorming), class: "btn btn-secondary m-1", title: gettext("Share") do %>

priv/gettext/de/LC_MESSAGES/default.po

@@ -107,7 +107,7 @@ msgstr "Neue Idee"
 msgid "New brainstorming"
 msgstr "Neues Brainstorming"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:71
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:73
 #, elixir-autogen, elixir-format
 msgid "New idea"
 msgstr "Neue Idee"
@@ -122,7 +122,7 @@ msgstr "Neue Idee (Hotkey: i)"
 msgid "No ideas brainstormed"
 msgstr "Bisher keine Ideen vorhanden"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:121
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:123
 #, elixir-autogen, elixir-format
 msgid "Open new idea page (Hotkey: i)"
 msgstr "Öffne neue Ideen Dialog (Hotkey: i)"
@@ -147,12 +147,12 @@ msgstr "Speichere diesen Link, um das Brainstorming zukünftig zu bearbeiten ode
 msgid "Saving..."
 msgstr "Speichere..."
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:33
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:34
 #, elixir-autogen, elixir-format
 msgid "Sort by label"
 msgstr "Sortiere nach Label"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:30
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:31
 #, elixir-autogen, elixir-format
 msgid "Sort by likes"
 msgstr "Sortiere nach Likes"
@@ -320,12 +320,12 @@ msgstr "Trete meinem Brainstorming bei."
 msgid "Mindwendel Brainstorming"
 msgstr "Mindwendel Brainstorming"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:37
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:39
 #, elixir-autogen, elixir-format
 msgid "Share"
 msgstr "Teilen"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:95
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:97
 #, elixir-autogen, elixir-format
 msgid "Share brainstorming"
 msgstr "Teile Dein Brainstorming"
@@ -355,7 +355,7 @@ msgstr "Idee bearbeiten"
 msgid "Idea created updated"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:83
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:85
 #, elixir-autogen, elixir-format
 msgid "Update idea"
 msgstr "Idee bearbeiten"
@@ -376,12 +376,12 @@ msgstr "Bist du sicher, dass das Brainstorming geleert werden soll?"
 msgid "Empty brainstorming"
 msgstr "Leere das Brainstorming"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:34
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:35
 #, elixir-autogen, elixir-format
 msgid "Label"
 msgstr "Label"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:31
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:32
 #, elixir-autogen, elixir-format
 msgid "Likes"
 msgstr "Likes"
@@ -406,7 +406,7 @@ msgstr "Nutzern das Verschieben von Ideen erlauben"
 msgid "Back"
 msgstr "Zurück"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:118
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:120
 #, elixir-autogen, elixir-format
 msgid "+"
 msgstr "+"

priv/gettext/default.pot

@@ -106,7 +106,7 @@ msgstr ""
 msgid "New brainstorming"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:71
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:73
 #, elixir-autogen, elixir-format
 msgid "New idea"
 msgstr ""
@@ -121,7 +121,7 @@ msgstr ""
 msgid "No ideas brainstormed"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:121
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:123
 #, elixir-autogen, elixir-format
 msgid "Open new idea page (Hotkey: i)"
 msgstr ""
@@ -146,12 +146,12 @@ msgstr ""
 msgid "Saving..."
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:33
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:34
 #, elixir-autogen, elixir-format
 msgid "Sort by label"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:30
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:31
 #, elixir-autogen, elixir-format
 msgid "Sort by likes"
 msgstr ""
@@ -319,12 +319,12 @@ msgstr ""
 msgid "Mindwendel Brainstorming"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:37
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:39
 #, elixir-autogen, elixir-format
 msgid "Share"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:95
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:97
 #, elixir-autogen, elixir-format
 msgid "Share brainstorming"
 msgstr ""
@@ -354,7 +354,7 @@ msgstr ""
 msgid "Idea created updated"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:83
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:85
 #, elixir-autogen, elixir-format
 msgid "Update idea"
 msgstr ""
@@ -375,12 +375,12 @@ msgstr ""
 msgid "Empty brainstorming"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:34
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:35
 #, elixir-autogen, elixir-format
 msgid "Label"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:31
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:32
 #, elixir-autogen, elixir-format
 msgid "Likes"
 msgstr ""
@@ -405,7 +405,7 @@ msgstr ""
 msgid "Back"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:118
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:120
 #, elixir-autogen, elixir-format
 msgid "+"
 msgstr ""

priv/gettext/en/LC_MESSAGES/default.po

@@ -107,7 +107,7 @@ msgstr ""
 msgid "New brainstorming"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:71
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:73
 #, elixir-autogen, elixir-format
 msgid "New idea"
 msgstr ""
@@ -122,7 +122,7 @@ msgstr ""
 msgid "No ideas brainstormed"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:121
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:123
 #, elixir-autogen, elixir-format
 msgid "Open new idea page (Hotkey: i)"
 msgstr ""
@@ -147,12 +147,12 @@ msgstr ""
 msgid "Saving..."
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:33
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:34
 #, elixir-autogen, elixir-format
 msgid "Sort by label"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:30
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:31
 #, elixir-autogen, elixir-format
 msgid "Sort by likes"
 msgstr ""
@@ -320,12 +320,12 @@ msgstr "Join my brainstorming"
 msgid "Mindwendel Brainstorming"
 msgstr "Mindwendel Brainstorming"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:37
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:39
 #, elixir-autogen, elixir-format
 msgid "Share"
 msgstr "Share"
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:95
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:97
 #, elixir-autogen, elixir-format
 msgid "Share brainstorming"
 msgstr "Share brainstorming"
@@ -355,7 +355,7 @@ msgstr ""
 msgid "Idea created updated"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:83
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:85
 #, elixir-autogen, elixir-format
 msgid "Update idea"
 msgstr ""
@@ -376,12 +376,12 @@ msgstr "Are you sure that you want to delete this brainstorming?"
 msgid "Empty brainstorming"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:34
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:35
 #, elixir-autogen, elixir-format
 msgid "Label"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:31
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:32
 #, elixir-autogen, elixir-format
 msgid "Likes"
 msgstr ""
@@ -406,7 +406,7 @@ msgstr "Allow users to change the order of ideas"
 msgid "Back"
 msgstr ""
 
-#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:118
+#: lib/mindwendel_web/live/brainstorming_live/show.html.heex:120
 #, elixir-autogen, elixir-format
 msgid "+"
 msgstr ""

test/mindwendel/ideas_test.exs

@@ -91,13 +91,15 @@ defmodule Mindwendel.IdeasTest do
       second_idea =
         Factory.insert!(:idea,
           brainstorming: brainstorming,
-          label: Enum.at(brainstorming.labels, 0)
+          label: Enum.at(brainstorming.labels, 0),
+          inserted_at: ~N[2022-01-01 15:06:30]
         )
 
       third_idea =
         Factory.insert!(:idea,
           brainstorming: brainstorming,
-          label: Enum.at(brainstorming.labels, 1)
+          label: Enum.at(brainstorming.labels, 1),
+          inserted_at: ~N[2021-01-01 15:06:30]
         )
 
       Ideas.update_ideas_for_brainstorming_by_labels(brainstorming.id)

test/mindwendel_web/live/brainstorming_live/show_sort_by_label_test.exs

@@ -1,26 +1,37 @@
 defmodule MindwendelWeb.BrainstormingLive.ShowSortByLabelTest do
   use MindwendelWeb.ConnCase
   import Phoenix.LiveViewTest
+  alias Mindwendel.Brainstormings
 
   alias Mindwendel.Factory
 
   setup do
-    %{brainstorming: Factory.insert!(:brainstorming)}
+    moderating_user = Factory.insert!(:user)
+    brainstorming = Factory.insert!(:brainstorming)
+    Brainstormings.add_moderating_user(brainstorming, moderating_user)
+    %{brainstorming: brainstorming, moderating_user: moderating_user}
   end
 
   test "contains button \"Sort by labels\"", %{
     conn: conn,
-    brainstorming: brainstorming
+    brainstorming: brainstorming,
+    moderating_user: moderating_user
   } do
     {:ok, show_live_view, _html} =
-      live(conn, Routes.brainstorming_show_path(conn, :show, brainstorming))
+      conn
+      |> init_test_session(%{current_user_id: moderating_user.id})
+      |> live(Routes.brainstorming_show_path(conn, :show, brainstorming))
 
     assert show_live_view
            |> has_element?(html_selector_button_sort_by_labels(brainstorming))
   end
 
   # The order of the labels is the defined by the column position_order
-  test "sort ideas by labels", %{conn: conn, brainstorming: brainstorming} do
+  test "sort ideas by labels", %{
+    conn: conn,
+    brainstorming: brainstorming,
+    moderating_user: moderating_user
+  } do
     idea_with_first_label =
       Factory.insert!(:idea, %{
         brainstorming: brainstorming,
@@ -36,7 +47,9 @@ defmodule MindwendelWeb.BrainstormingLive.ShowSortByLabelTest do
     idea_without_label = Factory.insert!(:idea, %{brainstorming: brainstorming})
 
     {:ok, show_live_view, _html} =
-      live(conn, Routes.brainstorming_show_path(conn, :show, brainstorming))
+      conn
+      |> init_test_session(%{current_user_id: moderating_user.id})
+      |> live(Routes.brainstorming_show_path(conn, :show, brainstorming))
 
     rendered =
       show_live_view