Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): Bump oban from 2.17.3 to 2.17.6 #246

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Bumps oban from 2.17.3 to 2.17.6.

Release notes

Sourced from oban's releases.

v2.17.6

Enhancements

  • [Cron] Include cron indicator and original cron expression in meta.

    When the Cron plugin inserts jobs the original, unnormalized cron expression is now stored in a job's meta under the cron_expr key. For compatibility with Pro's DynamicCron, meta also has cron: true injected.

  • [Worker] Change backoff/1 spec to allow immediate rescheduling by returning 0

    The callback now specifies a non_neg_integer to allow retrying 0 seconds into the future. This matches the abilitiy to use {:snooze, 0}.

Bug Fixes

  • [Notifier] Revert using single connection to deliver notices.

    Production use of the single notifier connection in various environments showed timeouts from bottlenecks in the single connection could crash the connection and start new ones, leaving extra idle processes. In addition, Use interpolated NOTIFY instead of pg_notify with a JSON argument added parsing load because it could no longer use prepared statements.

  • [Worker] Apply custom backoff on timeout and unhandled exit

    A worker's custom backoff/1 wasn't applied after a TimeoutError or unhandled exit. That's because the producer stores the executor struct before resolving the worker module. Now the module is resolved again to ensure custom backoff/1 are used.

  • [Job] Revert setting the default priority key in Job schema.

    The Ecto default was removed to allow overriding the default in the database and it was purposefully removed.

v2.17.5

Enhancements

  • [Notifier] Use the Postgres notifier's connection to deliver notifications.

    The Postgres notifier holds a single connection for listening and relaying messages. However, it wasn't used to dispatch messages; that was left to queries through the Ecto pool. Those queries were noisy and put unnecessary load on the pool, particularly from insert notifications.

    Now notifications are delivered through the notifier's connection—they don't require a pool checkout, and they won't clutter Ecto logs or telemetry.

  • [Engine] Emit insert trigger notification directly from Engine callbacks.

    Notifications are now sent from the engine, within the insert_* telemetry block, so the timing impact is visible. In addition, notifications aren't emitted for scheduled jobs, as there's nothing ready for producers to fetch.

Bug Fixes

  • [Notifier] Track and compare sonar pings using the correct time unit.

    The notifier's status tracker pruned stale nodes using mismatched time units, causing constant status change events despite nothing changing. This ensures the recorded and compared times are both milliseconds, not a mixture of seconds and native time.

  • [Cron] Retain @reboot cron entries until node becomes leader.

    With rolling deploys it is frequent that a node isn't the leader the first time cron evaluates. However, @reboot expressions were discarded after the first run, which prevented reboots from being inserted when the node acquired leadership.

  • [Oban] Require Ecto v3.10 to support materialized flag added in the previous patch.

... (truncated)

Changelog

Sourced from oban's changelog.

v2.17.6 — 2024-03-01

Enhancements

  • [Cron] Include cron indicator and original cron expression in meta.

    When the Cron plugin inserts jobs the original, unnormalized cron expression is now stored in a job's meta under the cron_expr key. For compatibility with Pro's DynamicCron, meta also has cron: true injected.

  • [Worker] Change backoff/1 spec to allow immediate rescheduling by returning 0

    The callback now specifies a non_neg_integer to allow retrying 0 seconds into the future. This matches the abilitiy to use {:snooze, 0}.

Bug Fixes

  • [Notifier] Revert using single connection to deliver notices.

    Production use of the single notifier connection in various environments showed timeouts from bottlenecks in the single connection could crash the connection and start new ones, leaving extra idle processes. In addition, Use interpolated NOTIFY instead of pg_notify with a JSON argument added parsing load because it could no longer use prepared statements.

  • [Worker] Apply custom backoff on timeout and unhandled exit

    A worker's custom backoff/1 wasn't applied after a TimeoutError or unhandled exit. That's because the producer stores the executor struct before resolving the worker module. Now the module is resolved again to ensure custom backoff/1 are used.

  • [Job] Revert setting the default priority key in Job schema.

    The Ecto default was removed to allow overriding the default in the database and it was purposefully removed.

v2.17.5 — 2024-02-25

Enhancements

  • [Notifier] Use the Postgres notifier's connection to deliver notifications.

    The Postgres notifier holds a single connection for listening and relaying messages. However, it wasn't used to dispatch messages; that was left to queries through the Ecto pool. Those queries were noisy and put unnecessary load on the pool, particularly from insert notifications.

    Now notifications are delivered through the notifier's connection—they don't require a pool checkout, and they won't clutter Ecto logs or telemetry.

  • [Engine] Emit insert trigger notification directly from Engine callbacks.

... (truncated)

Commits
  • 25b6481 Release v2.17.6
  • 019c60b Revert using single connection to deliver notices
  • 8401bbd Change c:backoff/1 to allow immediate rescheduling
  • 8aa5d76 Apply custom backoff on timeout and unhandled exit
  • d9d8480 Include cron indicator and expression in meta (#1049)
  • 12c4cdf Revert "Restore default job priority (#1035)"
  • febfc63 Release v2.17.5
  • a3e8a99 Emit insert notification directly from Engine
  • fb87366 Use notifier connection to deliver notifications
  • 3d2e1fb Use :connected flag in isolated notifier
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [oban](https://github.com/sorentwo/oban) from 2.17.3 to 2.17.6.
- [Release notes](https://github.com/sorentwo/oban/releases)
- [Changelog](https://github.com/sorentwo/oban/blob/main/CHANGELOG.md)
- [Commits](oban-bg/oban@v2.17.3...v2.17.6)

---
updated-dependencies:
- dependency-name: oban
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code labels Mar 4, 2024
@nwittstruck nwittstruck merged commit 784ca08 into master Mar 5, 2024
5 checks passed
@nwittstruck nwittstruck deleted the dependabot/hex/oban-2.17.6 branch March 5, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant