Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix flash alerts after phoenix 1.7 upgrade #232

Merged

Conversation

nwittstruck
Copy link
Contributor

Further Notes

  • Phoenix 1.7 changed the way flash messages are handled. This lead to empty, but visible alert boxes in bootstrap.

New Features / Enhancements

  • To fix this, the code now validates whether the flash is set before rendering the alerts

@nwittstruck nwittstruck linked an issue Jan 26, 2024 that may be closed by this pull request
1 task
@nwittstruck nwittstruck merged commit 3743338 into master Jan 26, 2024
5 checks passed
@nwittstruck nwittstruck deleted the 229-bug-fix-flash-alerts-after-phoenix-17-upgrade branch January 26, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: fix Flash alerts after phoenix 1.7 upgrade
1 participant