use proper dependent preloads

b310-digital · Nov 8, 2024 · f56c3e6 · f56c3e6
1 parent aaa88c0
commit f56c3e6
Showing 1 changed file with 2 additions and 11 deletions.
diff --git a/lib/mindwendel/lanes.ex b/lib/mindwendel/lanes.ex
@@ -102,16 +102,7 @@ defmodule Mindwendel.Lanes do
 
     lane_query
     |> Repo.all()
-    |> Repo.preload(
-      ideas:
-        ideas_advanced_query
-        |> preload([
-          :link,
-          :likes,
-          :idea_labels,
-          :files
-        ])
-    )
+    |> Repo.preload(ideas: {ideas_advanced_query, [:link, :likes, :idea_labels, :files]})
   end
 
   defp build_ideas_query_with_filter(%{filter_labels_ids: filter_labels_ids}) do
@@ -128,7 +119,7 @@ defmodule Mindwendel.Lanes do
   end
 
   defp build_ideas_query_with_filter(%{} = _filters) do
-    Idea
+    from(idea in Idea)
   end
 
   @doc """