make simplified_attached_file_type more robust to handle nil case (#500)

b310-digital · Nov 27, 2024 · 397aaf3 · 397aaf3
1 parent b16e214
commit 397aaf3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/mindwendel/attachments.ex b/lib/mindwendel/attachments.ex
@@ -29,7 +29,7 @@ defmodule Mindwendel.Attachments do
 
   """
   def simplified_attached_file_type(file_type) do
-    case String.split(file_type, "/") do
+    case String.split(file_type || "", "/") do
       ["image", _] -> "image"
       [_, "pdf"] -> "pdf"
       [_, _] -> "misc"

diff --git a/test/mindwendel/attachments_test.exs b/test/mindwendel/attachments_test.exs
@@ -20,9 +20,17 @@ defmodule Mindwendel.AttachmentsTest do
       assert Attachments.simplified_attached_file_type("application/pdf") == "pdf"
     end
 
-    test "simplifies the file type for an unknown file" do
+    test "simplifies the file type for an unknown type" do
       assert Attachments.simplified_attached_file_type("application_unknown") == "misc"
     end
+
+    test "simplifies the file type for an empty type" do
+      assert Attachments.simplified_attached_file_type("") == "misc"
+    end
+
+    test "simplifies the file type for a missing type" do
+      assert Attachments.simplified_attached_file_type(nil) == "misc"
+    end
   end
 
   describe "delete_attached_file" do