Skip to content

Commit

Permalink
Remove test-prepare
Browse files Browse the repository at this point in the history
test-prepare seems to be unneeded and potentially  harmful imo:

* the tests run fine without it, as `mix test` runs pending migrations
* reset also runs setup which runs the seeds which shouldn't
be in the test DB env unless we want to use them as fixtures but
then it'd probably better to separate dev seeds from test fixtures

So, I have it all running locally without ever running it 👍
  • Loading branch information
PragTob committed Sep 17, 2024
1 parent 8ad8d42 commit 1704714
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
6 changes: 0 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,6 @@ mindwendel is built on top of:
docker compose up --build -d
```

- Ensure your database is running and reset your database

```bash
docker compose exec app mix ecto.test.prepare
```

- Run the test

```bash
Expand Down
1 change: 0 additions & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ defmodule Mindwendel.MixProject do
[
"ecto.reset": ["ecto.drop", "ecto.setup"],
"ecto.setup": ["ecto.create", "ecto.migrate", "run priv/repo/seeds.exs"],
"ecto.test.prepare": ["cmd MIX_ENV=test mix ecto.reset"],
setup: ["deps.get", "ecto.setup", "cmd npm install --prefix assets"],
test: ["ecto.create --quiet", "ecto.migrate --quiet", "test"],
"assets.deploy": [
Expand Down

0 comments on commit 1704714

Please sign in to comment.