Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-4633: Ensure description inactivator member inactivation is possible #753

Open
wants to merge 4 commits into
base: 7.x
Choose a base branch
from

Conversation

AAAlinaaa
Copy link
Contributor

No description provided.

@AAAlinaaa AAAlinaaa self-assigned this Feb 2, 2021
@apeteri
Copy link
Member

apeteri commented Feb 3, 2021

I think this is a too heavy-handed approach that adds a lot of complexity for little gain. Take a look at how the delete/retire action in the "references" page handles language reference set members: the only thing that needs to be done is setting the inactivation indicator on the referenced component (description in this case) to null (this is also needed so that the "descriptions" page updates the status column before the editor is saved).

Edit: OK, there is another change which I should look at; I will add another note over in the other repository.

@cmark
Copy link
Member

cmark commented Feb 4, 2021

Agree with @apeteri. Let's discuss the alternative solutions first, then decide on which would be the best.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2021
@cmark cmark added pinned and removed wontfix labels Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants