P2 rerereview #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change has already been implemented.
Closed
|
The simplification of the admin form path issue(c2530bb) wont work, drupal will look for the file in Will fix the other things and we'll have another commit ready later today, with a few other minor adjustments. |
|
@BirkAndMe I see your point. The problem has been revealed by I have created a PR for fixing the situation (ding2#249), but we should not wait for that to land. With that in mind c2530bb should be left out. |
BirkAndMe
pushed a commit
that referenced
this pull request
May 1, 2019
Squashed commits: commit 8221ae4d8d685675d7157c6c330e51e602983171 Merge: c168b0891 7e8a08a38 Author: Thomas Fini Hansen <[email protected]> Date: Tue Mar 5 11:32:20 2019 +0100 Merge branch 'master' into p2-tests-merged commit c168b08914c62334429e786db2d35c80abed29d1 Merge: 72707a9c6 701875fff Author: Kasper Garnaes <[email protected]> Date: Tue Feb 14 12:50:13 2017 +0100 Merge branch 'master' into reload-p2-tests-merged commit 72707a9c6d7c319b7dbf792b5fe6e0cd50926c8f Author: Thomas Fini Hansen <[email protected]> Date: Thu Dec 15 11:23:45 2016 +0100 Remove debugging statement commit 50b915c5293eee0b22db66762b02c2f6e6800b8a Merge: 52cd23f4a e68b0dc6b Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 22:14:38 2016 +0100 Merge branch 'master' into p2-tests-merged commit 52cd23f4acf3ed6a086ccb0359ced9da2cd79200 Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 22:12:00 2016 +0100 Remove slash that's not there anymore commit 1a7a8da03d67629c4e629e0616d616ec2b0bc812 Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 22:11:37 2016 +0100 Fix style commit cd4dd1006d9d635b02e117e025c56bf6a16253f9 Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 21:35:45 2016 +0100 Use translated status text Apparently it's been fixed upstream. commit fae798ba3b40971ed22d83a9e4bc69c744cb2e5d Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 21:33:21 2016 +0100 Fix wait timeouts waitFor() is in seconds, not milliseconds. commit 4517d56a387ef50da4b16734b61a68a2a19c069f Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 20:57:40 2016 +0100 Handle collections commit c22ac76a840a3337afc16a9c658660b0919f66b1 Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 20:57:14 2016 +0100 Facilitate chaining commit 2eb0989d9730437e68c8449db7a3110819c877a0 Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 20:57:02 2016 +0100 Break out on first result commit aff8ca12ddd6bd508719ffcec9787975c750d6e9 Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 20:56:45 2016 +0100 Remove comments commit 9160b753f06bf3c6788718d3c8946bd7a94e3c84 Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 14:27:58 2016 +0100 Remove tests of deleted module commit 98e649d27f1c9616ec04a43200ebc31e0cb751fc Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 14:10:12 2016 +0100 Update opensearch as the previous has been discontinued commit b944f1746d4f3542a43ab515b1e5ca54d1c9f1d5 Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 14:02:34 2016 +0100 Fix uid finding commit ba709ca6ea1fc0ccae3ace69798033f742eacb4e Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 14:02:17 2016 +0100 Clean up uid handling. commit d2771a384645aa6ce10bf269f0ac52086cd5b90c Merge: 6173bcbc4 43bfd5bf8 Author: Thomas Fini Hansen <[email protected]> Date: Wed Dec 14 10:25:12 2016 +0100 Merge branch 'master' into p2-tests-merged commit 6173bcbc4dbd64460d9f66be8eb7fe4a99c22186 Author: Thomas Fini Hansen <[email protected]> Date: Tue Oct 11 22:23:26 2016 +0200 Flesh out connie openlist provider a bit more commit 97ac7ef25d2bde0b06514a1b459401d8c5142ad4 Author: Thomas Fini Hansen <[email protected]> Date: Mon Oct 10 20:17:40 2016 +0200 Fix code style error commit ddf5d781be7039a04e7cfc8102fe94af2a0b8fc0 Author: Thomas Fini Hansen <[email protected]> Date: Mon Oct 10 15:54:21 2016 +0200 Don't fail on unexpected messages commit cfce4dcc806a6d00a71cf3ab38770841121d5163 Author: Thomas Fini Hansen <[email protected]> Date: Mon Oct 10 15:39:16 2016 +0200 Fix translations. commit e90a8da0e3f1edac0197a30382a294eebb9ecde2 Author: Thomas Fini Hansen <[email protected]> Date: Mon Oct 10 15:38:09 2016 +0200 Fix include paths in Connie commit 090c3f0c991d772a550612b075908a6c259abdbe Merge: a47b7f99a b14260b88 Author: Thomas Fini Hansen <[email protected]> Date: Fri Oct 7 13:38:00 2016 +0200 Merge remote-tracking branch 'reload/p2-tests-fixed-enhancement-1679' into p2-tests-merged commit a47b7f99acc642432aff2514c9e1081938a0e74a Merge: 41ee5135e c54a6ba9e Author: Thomas Fini Hansen <[email protected]> Date: Thu Oct 6 14:03:24 2016 +0200 Merge branch 'master' into p2-tests-merged commit b14260b88b456c9b3b9ad160b9d947179df2ebb6 Author: Morten Bartvig <[email protected]> Date: Tue Aug 9 14:25:23 2016 +0200 1679: Added exception when tag doesn't exist. commit 47abcdd95fdf6dc3e02d10966fe16489796ed4ab Author: Morten Bartvig <[email protected]> Date: Tue Aug 9 13:47:15 2016 +0200 1679: Changed title of feature. commit 60e391c7d2760a7233996ecc7a1289b904770640 Author: Morten Bartvig <[email protected]> Date: Tue Aug 9 13:46:57 2016 +0200 1679: Change method of finding tag on page. commit 8d4bbf65896bbd7d4b4d4ff8eb3d3bd697b68c2b Author: Morten Bartvig <[email protected]> Date: Tue Aug 9 12:28:31 2016 +0200 1679: Changed translated text. commit 46347bc6d66097a5395ba0e61ea9ba642d0594ac Author: Morten Bartvig <[email protected]> Date: Tue Aug 9 12:28:14 2016 +0200 1679: Changed material because it doesn't exist any more. commit 5ac8e3084c107ff94d9f9dc810064a3e531ed8cd Author: Morten Bartvig <[email protected]> Date: Tue Aug 9 10:59:29 2016 +0200 1679: Removed paths from debt, wayf, and user_consent providers from connie. commit f442919a244cc5c49434ed16d18db4448745ceaa Author: Morten Bartvig <[email protected]> Date: Tue Aug 9 10:42:55 2016 +0200 1679: Removed path from connie_openlist ding provider file name. commit 45219d618a85e3566c157ea633003802a7c5044d Author: Morten Bartvig <[email protected]> Date: Fri Aug 5 11:13:49 2016 +0200 1679: Added translations for P2 to ding translaitons. commit ab8dc100827ffa868fefedd9bdef532550bbfd79 Author: Morten Bartvig <[email protected]> Date: Fri Aug 5 11:12:41 2016 +0200 1679: Default to empty array if none exists to prevent php warnings. commit 278f05f17f35fe96e803c1966d462ee3a551de9d Author: Morten Bartvig <[email protected]> Date: Wed Aug 3 13:53:01 2016 +0200 1679: Remove tag that prevents scenarios to be run with selenium on circle. commit bcc25fced0ba74c35d898faa1a9771442f42a9c0 Author: Morten Bartvig <[email protected]> Date: Wed Aug 3 13:51:41 2016 +0200 1679: Added Ding2MessagesContext to get notices and warnings. commit 6d8b92b11a3ce681ac8ab081c06fa1db107986f4 Author: Morten Bartvig <[email protected]> Date: Wed Aug 3 13:01:53 2016 +0200 1679: Changed order of vset commands to avoid dialog in CLI. commit dbb76c2809b442e707848f8b6e7c180936e5a188 Author: Morten Bartvig <[email protected]> Date: Wed Aug 3 12:22:21 2016 +0200 1679: Fixed material and added material to selector. commit db657b7f970cc69806838d8cbd46c2f474a62109 Author: Morten Bartvig <[email protected]> Date: Wed Aug 3 12:21:23 2016 +0200 1679: Code removed: link already fetched, and page already visited. commit ff998d9eef07bc5805f16fb7a2d09528fec4ebeb Author: Morten Bartvig <[email protected]> Date: Wed Aug 3 12:19:10 2016 +0200 1679: Create list link changed. commit 761d41302df0d1165446b9efce2bd20e3a6e8aa0 Author: Morten Bartvig <[email protected]> Date: Wed Aug 3 12:18:36 2016 +0200 1679: Added docblock 'throws' comment. commit 41ee5135e106a5457ffb4c3998802076aca131a0 Merge: 856f3d8a4 f2fb31dbc Author: Thomas Fini Hansen <[email protected]> Date: Fri Jul 8 10:41:45 2016 +0200 Merge remote-tracking branch 'ding/master' into p2-tests-merged commit 856f3d8a484d0bde2912892a429e7cdbf8767a49 Author: Thomas Fini Hansen <[email protected]> Date: Wed Jul 6 14:33:28 2016 +0200 Fix code style commit de7472843dde05267e7b914958c03a95edde70fb Author: Thomas Fini Hansen <[email protected]> Date: Wed Jul 6 13:51:18 2016 +0200 Don't enable P2 in makefile It's enabled per default. commit 2dc17d7dcd99623177d2ffa5765a031af9c6cee0 Author: Thomas Fini Hansen <[email protected]> Date: Wed Jul 6 13:50:31 2016 +0200 Remove P2 from make file It's included in core now. commit 08c5fc731941969f20c9d159f6a42da600a1e2f4 Merge: c2e677f7b f24c27315 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jul 5 08:45:03 2016 +0200 Merge remote-tracking branch 'origin/master' into p2-tests commit c2e677f7ba979fda7b5d0218e2068f1e0a5d2727 Author: Thomas Fini Hansen <[email protected]> Date: Tue Apr 5 11:48:16 2016 +0200 Fix typo commit 8bfca8842606e10a76cc44e27f3ae3feb8004faf Merge: b1f317123 8bca11dbc Author: Thomas Fini Hansen <[email protected]> Date: Tue Feb 9 11:09:05 2016 +0100 Merge pull request #22 from reload/follow-tags-moredropdown Follow tags moredropdown commit 8bca11dbcca88de8627f13100e20a71f302bc9cb Author: Morten Bartvig <[email protected]> Date: Mon Feb 8 08:35:15 2016 +0100 Choose dropdown based on content of link. commit b1f3171236c5f66c0054fa312739bf877d516aef Merge: 2e4590c77 3bd401807 Author: Thomas Fini Hansen <[email protected]> Date: Fri Feb 5 15:02:48 2016 +0100 Merge pull request #21 from reload/no-circle-selenium Remove 'Unfollow a public list' from being run with selenium on CircleCI commit de49f3c277ffde126b3ff054cacfc87d0482552b Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 15:00:46 2016 +0100 Changed selecting follow link to use dropdown function. commit 3bd4018079de544d5ef4046e5a67ea13f0f4b742 Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 14:31:03 2016 +0100 Remove 'Unfollow a public list' from being run with selenium on CircleCI. commit 2e4590c7718801c3c0da2b75cb19ec8aa2762161 Merge: 5c2fe6cb0 5224494eb Author: Morten <[email protected]> Date: Fri Feb 5 14:11:26 2016 +0100 Merge pull request #20 from reload/disable-tests Disable tests commit 5c2fe6cb0bf35b22dc4a7e50235530d73ed73e03 Merge: 5391fb9d1 1fde4f6b9 Author: Thomas Fini Hansen <[email protected]> Date: Fri Feb 5 13:45:20 2016 +0100 Merge pull request #19 from reload/general-fixes General fixes commit 1fde4f6b9486105b3a4486cba401724ce19302d4 Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 12:33:58 2016 +0100 Remove material ids from tests, change descriptions of tests. Tests changed to be more consistent and use 'I log in as a different user' as a single step instead. Use material names instead of material ids. The names will be translated to a material id. FKB-70 commit 6cd0919a6aaed8dd6844cdd7a6a56347389d401d Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 11:42:41 2016 +0100 Removed scenarios and tests for testing consent checkbox. The tests for setting and unsetting the checkbox are obsolete. FKB-70 commit 315e1e23cbd95e5ba8febf0a64bf8be1f6e11874 Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 11:29:02 2016 +0100 Changed timeout to be seconds (not milliseconds) commit aee27c235744ecda245522b07f6b5c231d78edd6 Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 11:28:20 2016 +0100 Changed step definition and code accordingly. FKB-70 commit 74dc3f602fd748f3d8a1832a3f39731df575d661 Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 11:15:20 2016 +0100 Changed step definition changed from rebase. commit d37d08b2048fc97891fcb724c6bc73b12ee67ad7 Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 11:12:44 2016 +0100 Removed extra line from fail in rebase. commit a609fbbb9bca42e63db97f17ef81af789533da15 Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 11:03:26 2016 +0100 Moved notify author to follow author. FKB-70 commit a25f378bc5bb4d4a1f9cf03e1426c7e3f1348363 Author: Morten Bartvig <[email protected]> Date: Fri Feb 5 10:52:45 2016 +0100 Changed list names. FKB-70 commit fb1a82de5525269b90fcfa0b2711848e43a0004e Author: Morten Bartvig <[email protected]> Date: Thu Feb 4 16:52:55 2016 +0100 Changed descriptions and changed code. Descriptions changed to something shorter without material names. Changed code accordingly. FKB-70 commit 2dc5ab437727571df8112b211243b8e4d0b6160a Author: Morten Bartvig <[email protected]> Date: Thu Feb 4 15:55:22 2016 +0100 Changed phrasing of behat tests and changed code accordingly. Changed 'tag' to 'subject'. Removed specific materials in behat tests and added them to step definitions instead. FKB-70 commit 6bb629bf3bfa5ef01361c45cf169f696b9879434 Author: Morten Bartvig <[email protected]> Date: Thu Feb 4 12:39:32 2016 +0100 Changed timeout in waitFor, added test code. FKB-59 commit 8b7c31a5516338e5a9579fa6cff099ad7b3ebf8b Author: Morten Bartvig <[email protected]> Date: Thu Feb 4 12:38:54 2016 +0100 Changed behat definitions. FKB-59 commit 200ba8041c2ca9b0026156d8fb18da25ed4c2f7a Author: Morten Bartvig <[email protected]> Date: Thu Feb 4 09:52:56 2016 +0100 Added test for making list write shared. FKB-59 commit f2c2387d7c3ee64d3fd653fe15fc10c8390aa76f Author: Morten Bartvig <[email protected]> Date: Wed Feb 3 10:02:25 2016 +0100 Make list read shared. FKB-59 commit 5224494eb234e3f18831941b2b28862abafc6cb7 Author: Thomas Fini Hansen <[email protected]> Date: Fri Feb 5 12:55:07 2016 +0100 Fix thinko commit f837061d4338fcf81f824139110b4f0910e57a60 Author: Thomas Fini Hansen <[email protected]> Date: Fri Feb 5 12:29:14 2016 +0100 Add missing backslash commit 737291f907441bee8f8efe997ffd180a17eb985d Author: Thomas Fini Hansen <[email protected]> Date: Fri Feb 5 11:50:27 2016 +0100 Add previous loans predefined list commit a6c4aee57d090c3666b2404efdeeefc89390492c Author: Thomas Fini Hansen <[email protected]> Date: Fri Feb 5 11:23:47 2016 +0100 Disable rating tests on Selenium on Circle CI FontAwesome fails for some odd reason, and then the rating stars collapse to an unclickable element, causing the test to fail. Can't debug FontAwesome due to time restriction. commit 5391fb9d1aedcf60b09f1bf0c923fee60295a3dd Merge: 422fc3f15 c5bb7f2b5 Author: Thomas Fini Hansen <[email protected]> Date: Fri Feb 5 11:20:10 2016 +0100 Merge pull request #18 from reload/documentation Documentation commit 422fc3f152004eed318ea35de85396ae8539deb6 Merge: fe50ad4bd b967de41d Author: Morten <[email protected]> Date: Fri Feb 5 11:00:07 2016 +0100 Merge pull request #17 from reload/page-objects Page objects commit b967de41d6a83a83ac45a02a61e125af7860ee28 Author: Thomas Fini Hansen <[email protected]> Date: Thu Feb 4 19:13:48 2016 +0100 Fix waitFor timeout It's seconds, not milliseconds. commit 30e804e6649f308648f94a9baa4126273b5d36be Author: Thomas Fini Hansen <[email protected]> Date: Thu Feb 4 19:12:53 2016 +0100 Remove stray tag commit c5bb7f2b57f3bd10cda641a49778169122bbaba2 Author: Morten Bartvig <[email protected]> Date: Thu Feb 4 10:16:31 2016 +0100 Added php formatting on code block, removed whitespace. FKB-59 commit 963dccccf94f7dd26eb70cc49887f2963d0f5ff8 Author: Thomas Fini Hansen <[email protected]> Date: Wed Feb 3 22:02:01 2016 +0100 Remove stray newline commit 00ee0727c34e53becd248026d8fd59e32dfb096f Author: Thomas Fini Hansen <[email protected]> Date: Wed Feb 3 22:00:12 2016 +0100 Add more documentation and reorganize a bit commit 5e1a717404f7693663b3cb03f3fc04c4a10212ee Author: Thomas Fini Hansen <[email protected]> Date: Wed Feb 3 21:12:43 2016 +0100 Reformat and add documentation commit c17db682025ce853c633fee2082b191c67e39605 Author: Thomas Fini Hansen <[email protected]> Date: Wed Feb 3 19:50:29 2016 +0100 Fix broken test. commit f977145020f386dbcb5209f1732ac87f6e59df86 Author: Thomas Fini Hansen <[email protected]> Date: Tue Feb 2 13:34:24 2016 +0100 Refactor material list tests to use Page Objects Ideally, all tests should use the page object pattern rather than implementing page interaction themselves, but due to time constraints, only material_lists.feature has been refactored. commit fe50ad4bdc69f0a11bcfd5d16b3765ce17c75145 Merge: 00e4ffb27 b71798c5e Author: Thomas Fini Hansen <[email protected]> Date: Tue Feb 2 12:18:53 2016 +0100 Merge pull request #16 from reload/user-history Added behat test and code for user history. commit 12dbaef1a205c1a431172947a80d3fa03e60d100 Author: Morten Bartvig <[email protected]> Date: Mon Feb 1 11:46:49 2016 +0100 Added markdown code tag. commit 0289d14a5c855287ad68d1ced8e5b117de97b522 Author: Morten Bartvig <[email protected]> Date: Mon Feb 1 11:06:09 2016 +0100 Added initial doc for running behat. commit b2ac2a080a426cb896776e0facd08912c88e3db7 Author: Morten Bartvig <[email protected]> Date: Mon Feb 1 11:05:58 2016 +0100 Added initial doc for installing. commit e0423d755172953c97eacbf328651e43a72e2d96 Author: Morten Bartvig <[email protected]> Date: Mon Feb 1 10:20:09 2016 +0100 Added initial doc for troubleshooting. commit 223a3528057444aaf9f848357d48a2681be97e82 Author: Morten Bartvig <[email protected]> Date: Mon Feb 1 10:19:56 2016 +0100 Added initial doc for mocking. commit d50fa9563ee1b9972ad9e08410c2ec8160b3778d Author: Morten Bartvig <[email protected]> Date: Mon Feb 1 10:19:28 2016 +0100 Added initial motivation for Behat. commit f8364f90c91d5e75a352f66761ea5fa0f9a97922 Author: Morten Bartvig <[email protected]> Date: Mon Feb 1 10:19:06 2016 +0100 Added initial faq. commit a9c7f8f7fe8e83ba1bf4ac8baf00b475e0638ae4 Author: Morten Bartvig <[email protected]> Date: Mon Feb 1 10:18:53 2016 +0100 Added links to md documents. commit a0c409374d2b66730665ca23e99d3d069bfbdcf5 Author: Morten Bartvig <[email protected]> Date: Mon Feb 1 10:18:35 2016 +0100 Added link to 'how to write tests'. commit fe378cda8e722635f14eb3582f892d3657f72ff0 Author: Morten Bartvig <[email protected]> Date: Fri Jan 29 15:33:39 2016 +0100 Added initial 'how to write tests'. commit ef63c6f86e954e17b9ec453c03b80971019b4e17 Author: Morten Bartvig <[email protected]> Date: Fri Jan 29 15:33:12 2016 +0100 Added business logic and some intro text. commit 634f720a909e1cfbed7adbc2e8c675e3044b7b9c Author: Morten Bartvig <[email protected]> Date: Fri Jan 29 15:32:40 2016 +0100 Minor fix. commit 48c9fd9746a03f48b87e6a880f8db6a938082825 Author: Morten Bartvig <[email protected]> Date: Fri Jan 29 13:57:31 2016 +0100 Fixed link, added initial what-to-test. commit 1f9fee4cddd0f5283f2a7af0f9b347c68e50832e Author: Morten Bartvig <[email protected]> Date: Fri Jan 29 13:52:50 2016 +0100 Added documentation template. commit 2e105dd982a1c4e05e12a790b1403b66b4fb2d89 Author: Morten Bartvig <[email protected]> Date: Fri Jan 29 08:53:18 2016 +0100 Added scenarios for shared lists. commit 70a7b931e528ff3bd07457077264b8baf4d016c3 Author: Morten Bartvig <[email protected]> Date: Fri Jan 29 08:52:33 2016 +0100 Added waiting for element to exist. commit 885c4805e53bcadbbe1586b39266066452bd59aa Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 20:53:58 2016 +0100 Add another waitForPage commit 230cf5779c664a0c5f21aeaafa3a5195a0311512 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 20:31:28 2016 +0100 Add more scrollTos commit c37ed32017541a579d7100fd3189406606411850 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 20:07:45 2016 +0100 Escape quotes in xpath commit 1fc45fb8156fd884b1ef1d79bfb51324e4cabc56 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 17:21:58 2016 +0100 Reintroduce setting window size Tests started failing because PhantomJS would render the page at mobile resolutions, which hides some elements. However the previous sizes failed in Selenium on Circle as it's framebuffer doesn't seem to be that big. So we compromise on a small desktop size that works on Circle, but doesn't trigger mobile media types. commit 051aef4d97d1b2a6681807d0475b26976645ef1d Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 17:05:05 2016 +0100 Add more scrolling and waiting commit 387a2b6808ad03deec684876bf9c2ee7a2398d13 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 14:54:00 2016 +0100 Use proper method commit 4c28831e3a2da8647dae56cb5b84b46eea26c336 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 14:52:55 2016 +0100 Ignore waitForPage and scrollTo in non JS browser commit 91feae6e5375ef9bdfc7ea1f2551fad6e156998b Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 14:14:30 2016 +0100 Add some waitForPage and scrollTo calls commit f948f1be5ea2b3b363d9a3696d2737c49ed02dec Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 14:11:21 2016 +0100 Added waitForPage function commit aad6bd28a499c79cc970443bd74f7fed673bfa5e Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 14:11:08 2016 +0100 Scroll to star before clicking commit a67d5d3554f170fbf7bac822f35e62d8b9d312d4 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 14:01:59 2016 +0100 Add generic scrollTo function commit b71798c5e89ace4f6c205dbfe134a0d4e176c836 Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 12:49:44 2016 +0100 Added behat test and code for user history. Code for checking the list of previous loans. FKB-18 commit 2563c6df91db73096e6903f29c119bd312d69317 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 12:34:20 2016 +0100 Run tests in Selenium in parallel commit 00e4ffb270f67e98211a2bded69b70d28687191d Merge: 1403e2e1c 447de8f44 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 28 12:36:37 2016 +0100 Merge pull request #15 from reload/notify-author-list-changed Notify author list changed commit 447de8f44794b95516d65afb0506fb5543147b2a Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 10:39:01 2016 +0100 Changed behat step, changed test code. Go directly to a chosen material instead of searching, as it's more unstable (instead of an actual book the first search result could be a collection). commit 8ea6d9047b3c77fd5ec47bd1b341aac304c02c07 Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 09:32:01 2016 +0100 Fix css selector. FKB-5 commit c5ed0eca7c496ac981e6149f9cd704e1fe0710da Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 09:31:40 2016 +0100 Wait for the notifications to be updated. The notifications in the top menu won't be updated when the page has been loaded, so we have to wait for it to be updated. FKB-5 commit 3d54c5b1ce2283f7d899dca3958c484bfad39d4e Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 09:30:07 2016 +0100 Find search results in a different way. Also scroll to link before clicking it. commit 25ea4abf1d64f725a03fa42b5fab219a519bfc1f Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 09:29:23 2016 +0100 Get list id and go to list directly. Go to list directly instead of clicking on a link. commit f484ec21f665f9aeaa78738f260b5a47170314d5 Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 09:28:15 2016 +0100 Changed variable names. commit 62fa6c27950daf4cc372a1acb4a7b459121124e0 Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 09:24:51 2016 +0100 Go to list directly. Get the list id and go directly to list instead of finding link in html. FKB-5 commit 4b5b43e1e199a67d554441742dd5045e55a73d5c Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 09:23:26 2016 +0100 Scroll to elements before trying to click. This is a fix when running tests in selenium, as it doesn't always accept clicking a button when it's not currently visible. commit 6ff2bb1e26c6b663040566910dd28ee814ee8da6 Author: Morten Bartvig <[email protected]> Date: Thu Jan 28 09:22:13 2016 +0100 Added @javascript tags. FKB-5. commit 23f62565bc9ea471dd240d77ef21c5f40d8ab922 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 16:04:33 2016 +0100 Fixed function name. commit 6b5f928af8a8fb98dd6c2e593b97aba4757c3299 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 15:43:14 2016 +0100 Changed name of list. Changed name afte previous code change. commit 39a05ee0f3c5631e2218c67f2e7b0bfb0bd60d04 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 15:24:36 2016 +0100 Removed surplus function, changed variable name. commit 875c50a5241e96dd56c0e80cbf8bd3341e587ac5 Merge: bccf1803e 6d9d6ecd5 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 15:18:58 2016 +0100 Merge branch 'notify-author-list-changed' of github.com:reload/ding2 into notify-author-list-changed Conflicts: tests/features/bootstrap/P2Context.php commit bccf1803ea794536dc84de4a5d229d45a8a01719 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 15:00:10 2016 +0100 Changed function name. commit e3c42beef7bf43304c51d3179cc96be3843e3e21 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 14:00:47 2016 +0100 Added behat and step definitions for notify author. Behat descriptions for notifications when there are new materials for followed authors. FKB-5 commit 73413ca3b5fcd1a280ff6c13a5b0a570891264e1 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 11:33:19 2016 +0100 Fixed wrong selectors and problems with not finding more link. commit 1403e2e1cb2d5455696e24d8a4479b29daa95d98 Merge: 29e672c5a 519c66c39 Author: Morten <[email protected]> Date: Tue Jan 26 15:02:29 2016 +0100 Merge pull request #14 from reload/test-refactoring Test refactoring commit 6d9d6ecd5cdc80667f8cc4c824e40549bd87a7a4 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 15:00:10 2016 +0100 Changed function name. commit 519c66c39b99d33c610e3dc0dd2f2ca9ac8472b9 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 14:14:45 2016 +0100 Use scrollTo hack commit 51c27c32ecc06c9eb8d79b46973cd7ffc767a0dd Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 14:00:47 2016 +0100 Added behat and step definitions for notify author. Behat descriptions for notifications when there are new materials for followed authors. FKB-5 commit 95737389f625b6c41c28ffcb3994acf980394c93 Merge: 5caa24184 29e672c5a Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 13:40:49 2016 +0100 Merge branch 'p2-tests' into test-refactoring Conflicts: tests/features/bootstrap/P2Context.php commit 5caa24184bff6f80856086a0fbc0b37af35c2af8 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 13:26:11 2016 +0100 Move helper methods to top of class commit 2b969c20c05274c636ee3a3eed2056e3258a84ce Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 13:16:06 2016 +0100 Remove debugging commit 12262ef8f97585fb8e8847e54a06d972c99cc3fd Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 13:15:49 2016 +0100 Add gotoSearchPage and use it commit 5678e8a6caef8152cd6b8780369fb366a73155dd Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 13:11:27 2016 +0100 Add gotoListPage method and use it commit 5929a59f97628a6869ba25e3fec8db3693e12a31 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 12:53:29 2016 +0100 Use proper list names everywhere commit 7f929d91df31e60297d7b092707aed5dc79558fa Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 12:40:35 2016 +0100 Use common navigation function commit 129dc7367e3c9339628024d6c9bd64898600b8e9 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 11:33:19 2016 +0100 Fixed wrong selectors and problems with not finding more link. commit 29e672c5a185007a2da8aa082265a6ed26d96eff Merge: b23e5ff10 7365bdf1c Author: Morten <[email protected]> Date: Tue Jan 26 11:43:21 2016 +0100 Merge pull request #13 from reload/add-to-new-list-26 Add to new list test commit 9bf37760d3a713a3fe4975cf305c90f9cc20f2b8 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 11:18:01 2016 +0100 Go directly to list page Rather than visit the lists page. Works better in Selenium. commit ba3ba3df6d17d76d3c9ebaafead1d8256fd0fb84 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 11:04:28 2016 +0100 Fix reference to unknown property commit cc1341905aa0de45f4b7bfcd2a5e428e9b90d45d Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:54:16 2016 +0100 Add function for going to a users lists page commit d74db903aa104a9e4abdb720a861ffdc35cc858a Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:46:52 2016 +0100 Fix wrong object reference commit 6d69521b8063842a13746f9b895be4e8a70bb514 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:46:14 2016 +0100 Implement "add to new list" tests Also some refactoring. commit c0bb34fcdde955e989c474cf465bb018cc42d233 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:44:41 2016 +0100 Refactor moreDropdownSelect More useful to select by list title rather than href. commit b4a6a0aad2229cb27470376d1d0d5fcb2d46c413 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:43:16 2016 +0100 Remove unused lastCreatedList commit 2e701d84e32e5e8f367c1e171ed46330bb4ce47e Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:35:21 2016 +0100 Add missing public commit c356ef3a4fadb8344e122bc235aafec7226fa328 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 09:31:00 2016 +0100 Add "add to new list" screnario commit 319133e91a270d7bc7e0c5ef888a568f5375be6b Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 09:30:50 2016 +0100 Remove whitespace commit b23e5ff1067d35030de251364b04b31b2c73ae52 Merge: 39c93b5ec 6b059f951 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 11:30:08 2016 +0100 Merge pull request #11 from reload/evaluate-materials Rate materials commit 7365bdf1c87a6ba02b33700ace2ac6d0eef7ca55 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 11:18:01 2016 +0100 Go directly to list page Rather than visit the lists page. Works better in Selenium. commit f69db0966868680a48387f91f59b0e6de35fc917 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 11:04:28 2016 +0100 Fix reference to unknown property commit b13081705866229ad7726a600395850a957d3aac Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:54:16 2016 +0100 Add function for going to a users lists page commit cbda3d8f1812e72425db85baae3bf2e70067e3da Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:46:52 2016 +0100 Fix wrong object reference commit 4197e3587de97bb37e3a7ee7c87f6a66d1223648 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:46:14 2016 +0100 Implement "add to new list" tests Also some refactoring. commit 4cc4340683437232331724edd0af2b63cc360001 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:44:41 2016 +0100 Refactor moreDropdownSelect More useful to select by list title rather than href. commit f766ce4707ea80c5af78f766d45ef1e2d3532eb5 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:43:16 2016 +0100 Remove unused lastCreatedList commit e0f2d93e32f9ab1fcffed4515c36fb7858b3bddf Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 10:35:21 2016 +0100 Add missing public commit 6b059f951c0e11ab2578dcd00816cdae2d8944d1 Author: Morten Bartvig <[email protected]> Date: Tue Jan 26 09:51:22 2016 +0100 Add check to make sure element has been found with find(). commit 96c805868d8dc07a073551b8a9e8c05d0c982db2 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 09:31:00 2016 +0100 Add "add to new list" screnario commit 668de9abb9ce2a9ac95c9cff85cc8ecbd314121c Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 09:30:50 2016 +0100 Remove whitespace commit 39c93b5ec022624e00c740e867eb9c9da649d800 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 09:22:19 2016 +0100 Remove debugging commit 58564ce0954e0aabf59cbffe42463c884518109c Merge: 9427606bc 4ab193345 Author: Morten <[email protected]> Date: Tue Jan 26 09:05:56 2016 +0100 Merge pull request #12 from reload/remove-from-list-30 Remove from list 30 commit 4ab19334593fa816315954ff7ae8b90f6ae1bc4c Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 26 08:32:38 2016 +0100 Implement remove from list test and refactor commit 9427606bc606b1b21e3682bedceef9fbb7038cd0 Author: Morten Bartvig <[email protected]> Date: Mon Jan 25 15:28:51 2016 +0100 Added waitFor to be sure, the ajax request has finished. commit 30b8a54d054049da02e8a0a2a86b2f4cb097d2a7 Author: Morten Bartvig <[email protected]> Date: Mon Jan 25 14:02:56 2016 +0100 Changed first letter to lower case. They shouldn't be upper case because we want the Behat tests to be more normal language. commit e58e1ff3f3eaf4fb71e7adf604ebe1a2384a6225 Author: Morten Bartvig <[email protected]> Date: Mon Jan 25 13:44:48 2016 +0100 Behat definitions and step definitions for rating materials. FKB-60 FKB-19 FKB-20 commit 5bb4f2ff24870021de3cf826b57dc537e6dcd4e6 Author: Morten Bartvig <[email protected]> Date: Mon Jan 25 13:43:12 2016 +0100 Changed first letter to upper case. commit 92d917dd4b2c4a3495ca60324c17160e4285a87f Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 25 13:29:12 2016 +0100 Remove surplus arguments commit 6dd20f1ff5c000334bfe574bd5772e17939493ce Merge: ed8170171 fd8fc8356 Author: Morten <[email protected]> Date: Mon Jan 25 13:22:51 2016 +0100 Merge pull request #10 from reload/add-to-list-23 Test list adding commit 91ca59187aa70d3fb2ca5edc3a0dae239720bb06 Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 25 12:59:07 2016 +0100 Replace iReadTheListIdForListName with getListId commit 97372316cab58adffcf0571110ab9d619824f2b3 Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 25 12:58:38 2016 +0100 Remove unused step definitions commit fd8fc8356fb2d88c9b0791e03a6ba2b70f24e736 Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 25 12:45:44 2016 +0100 Test list adding Closes FKB-23. commit ed8170171633fe60ff1db693f10979d0eb468840 Merge: 1705e53bd 6d0a99ff3 Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 25 10:17:21 2016 +0100 Merge pull request #9 from reload/mock-connie Create mock openlist provider and fix up tests commit 6d0a99ff30b3882651d1034a492fa780450023b1 Merge: 31f320604 1705e53bd Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 25 10:14:25 2016 +0100 Merge branch 'p2-tests' into mock-connie Conflicts: tests/features/bootstrap/P2Context.php commit 31f320604ff13c42356fd426dc41569785e650af Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 25 09:49:48 2016 +0100 Use right field commit 83d6b2fe2e6e4ae7b04be4ee61d6ebbaeaaa472c Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 25 09:25:19 2016 +0100 Remove @no_messages_check from features commit 1705e53bd890ec13a8abc8ba2f4d4b7b829729e6 Author: Morten Bartvig <[email protected]> Date: Mon Jan 25 09:05:47 2016 +0100 Revert "Added phantomjs-installer." This reverts commit def970ed2ef4dd6f538276826117d934bd7b4d15. commit 4d99aeef3c1d420fcf57ca8c68cc2d27e86c36fd Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 22 13:01:44 2016 +0100 Clean up list handling in test commit 5d8cdcb4638c90a66d29ca444811ff1ccf002348 Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 22 13:30:48 2016 +0100 Fix wording commit 1bfa68953e5416a6a60c1ee4185987ef434095a4 Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 22 12:59:31 2016 +0100 Avoid error in Connie when devel isn't enabled commit ac0e3d2ef5d828fa7b6002f0f6a5432763554cad Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 22 11:57:07 2016 +0100 Disable messages check temporarily Until we can fix the bugs triggering failures in P2/Ding. commit ef8def886fa2248dcaefa959cfc76d95309b1c41 Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 22 11:22:36 2016 +0100 Don't assume pager on public lists page commit 9cb46a3cc9808679f9b706cde85a1f269078c708 Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 22 11:08:09 2016 +0100 Enable mod_rewrite commit d29f395558aa954ca102ba592f08ccdcc140b074 Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 22 10:42:15 2016 +0100 Start phantamjs on CI commit 117c831a90b889e86eb2beaa91eb66c8b730a1e7 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 21 13:13:21 2016 +0100 Make Ding2MessagesContext used per default commit 148e73f9839e652b0f99dc20fcf48772038491b9 Merge: 18a50dcbf b4405b876 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 21 13:10:37 2016 +0100 Merge branch 'p2-tests' into mock-connie Conflicts: tests/features/bootstrap/P2Context.php commit 18a50dcbf8eeb879280119db09afb1ca936827cd Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 21 12:58:05 2016 +0100 Make Ding2MessagesContext optional commit c8c0cddb39f9b0fc879a66e53ccef518cd0e22ff Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 21 12:53:50 2016 +0100 Update readme commit 0f469d85a8658deb52b64d4e8118c39a2e47c18d Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 21 12:45:05 2016 +0100 Enable mock provider in CI commit 5bc04f0d363db96bb1648626e64f37e7ccdd0e7e Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 21 12:43:41 2016 +0100 Implement mock openlist provider for testing Doesn't yet implement all known openlist requests. commit c94a6cb011787a55fed79fd3dbc418cc58e31c22 Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 14:21:19 2016 +0100 Added change to theListExists that was lost in the timespace continuum. commit b4405b87600949319a3e3f7f2448dbb50981381e Merge: 93c35f5e0 57f812a79 Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 13:35:33 2016 +0100 Merge branch 'public-lists' into p2-tests commit 57f812a79a10b39a5373b3b63651e5233001a170 Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 13:35:27 2016 +0100 Function assertElementNotOnPage doesn't return anything. commit e719def5f7b7ac3a2720683cea5246daef9c589a Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 13:35:05 2016 +0100 Function changed name. FKB-29 commit 93c35f5e038c93288017acc99feca079fbf2f48d Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 13:17:34 2016 +0100 Fixed changed function name. commit a5d70093fe3f8094bd374498c891ca8e8d6df829 Merge: f9f306c41 c9062a84a Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 13:16:22 2016 +0100 Merge branch 'public-lists' into p2-tests Conflicts: tests/features/bootstrap/P2Context.php tests/features/p2/public_lists.feature commit c9062a84aa4be089084aaa59ee379eea41bc69dc Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 13:13:18 2016 +0100 Added test functions for adding material. FKB-14 commit c3a088e9e8aff018b9dd3a777f7b1bb066b7995b Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 13:10:54 2016 +0100 Fixed variable name. FKB-14 commit 0618dc14633e5dcb1db425bd80d0036433c41a50 Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 13:10:30 2016 +0100 Don't test specifically for dvd material. Fix error message. FKB-14 commit 1ea04d4ab352be1c66877f3e64fddd56130cd107 Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 13:09:09 2016 +0100 Removed follow public as anonymous, added can't add content. Removed test for following public lists as anonymous users as this isn't relevant. Added test for other users not being able to add content to public lists. FKB-14 commit f9f306c41736ed1fb889c578f7d665eee0302b38 Merge: 915e893ae 4bb307c3d Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 11:46:09 2016 +0100 Merge branch 'follow-tags' into p2-tests Conflicts: tests/features/p2/public_lists.feature commit 4bb307c3d730ea924bcab3e3dc05bc5f371cdf8d Merge: 2802e5c30 2dd9e1b60 Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 11:42:53 2016 +0100 Merge branch 'follow-tags' of github.com:reload/ding2 into follow-tags Conflicts: tests/features/bootstrap/Ding2Context.php tests/features/bootstrap/P2Context.php tests/features/p2/follow_tags.feature commit 2802e5c303fad86c3d86b86a4e32e9302e4bd54a Author: Morten Bartvig <[email protected]> Date: Wed Jan 20 11:26:23 2016 +0100 Removed follow tag as anonymous, changed iAmFollowingTheTag function. commit 915e893aeb0f4afa2120a2f64b3fc18971adc909 Merge: 15259531a 2dd9e1b60 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 19 13:13:46 2016 +0100 Merge pull request #7 from reload/follow-tags Follow tags commit 15259531a632a5e6f56235fb6cbf8c24cda63734 Merge: 19eb782c3 aa84ecb2f Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 19 13:12:34 2016 +0100 Merge pull request #8 from reload/public-lists Public lists commit b492a7687b1049f9140a76d3c2e3e79737b6d97f Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 19 09:51:36 2016 +0100 Add basic setup to makefile. commit 0f8c15fe69ceb60ce4ca0b7a3de3b6f83b4fdf1d Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:14:32 2016 +0100 Changed behat test a little. We need more information than just searching for a tag, because the tag might not necessarily be on every material in the search result. FKB-27 commit 7a6b0617a252a6cba9ba0361f87fe8f23a913a7c Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:03:36 2016 +0100 Added test code for unfollow tag. FKB-27 commit ec1149ac31c6673f264cb0a5f8afb3992152a5a8 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:02:45 2016 +0100 Fixed selectors and check checkbox instead of clicking link. FKB-28 FKB-27 commit a73da75cd0b6a8ab781eedc44006326afdd8c432 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:01:42 2016 +0100 Removed wrong class name from css selector. commit e235c4b288b5e677f679df95420ef49a61c1adc4 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 11:19:48 2016 +0100 Added test code for following tags. FKB-28 FKB-27 commit 8d6be4ec13fc2d1060aea37024b45d5b89c38986 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 11:12:00 2016 +0100 Added tags, added unfollow. FKB-28 FKB-27 commit 6088ef7338956b4fc474a96c0926f8f02e841d41 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 10:38:58 2016 +0100 Behat tests for following tags. FKB-28. commit 8b4e5334c714e550233e79fd31c8a812bd94bd87 Author: Morten Bartvig <[email protected]> Date: Mon Jan 18 09:47:34 2016 +0100 Changed search term and added author. Only search for the author, but filter the author so we are sure to get the correct author. Removed hard-coded author name. commit 8a0ca9da86012afd81642ccddbcf75f5c9600d41 Author: Morten Bartvig <[email protected]> Date: Mon Jan 18 09:57:15 2016 +0100 Removed variable from function. Let the list name be implicit instead. commit 38356daf91c22892ebdd41753606dacab2344f01 Author: Morten Bartvig <[email protected]> Date: Mon Jan 18 09:26:21 2016 +0100 Changed filename, changed user story. commit 3ea05381651b35dbe0419647b96aebdb78c5b00c Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 15:52:51 2016 +0100 Only resize window when we're using Selenium. commit b90f3551fb24ead46c23b1b588022db1f22a4d6e Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:15:21 2016 +0100 Resize window to avoid problems with elements being invisible for the webdriver. commit 27ce694524921411cc2e2fba75d6aa432c93f113 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 10:09:54 2016 +0100 Removed tag. commit cf161421e634a9522545866aa8738fed3d5e348d Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 18 09:07:49 2016 +0100 Make files directory writable on Circle. commit b8124459246d9ed4f16948a4fc67e089f47a67d8 Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 15 12:25:24 2016 +0100 Add in missing cd. commit 42179d8671286b273aab8c4b37a867268084186f Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 15 11:46:27 2016 +0100 Add stub README. commit 8279cfaa5c6415fcb7daa6c148228b85ad0b8006 Author: Morten Bartvig <[email protected]> Date: Mon Jan 18 14:33:29 2016 +0100 Added behat and step definitions for following a public list as anonymous user. FKB-6. commit 19eb782c3f95217b7c7708688aee8dc6343acd1a Author: Morten Bartvig <[email protected]> Date: Mon Jan 18 09:47:34 2016 +0100 Changed search term and added author. Only search for the author, but filter the author so we are sure to get the correct author. Removed hard-coded author name. commit e03296699b0d50f2f10068dd2e4c64c20ce06aaa Author: Morten Bartvig <[email protected]> Date: Mon Jan 18 09:57:15 2016 +0100 Removed variable from function. Let the list name be implicit instead. commit 6d82edaab30cac2c6241bb2987bfd7c3c26c60ff Author: Morten Bartvig <[email protected]> Date: Mon Jan 18 09:26:21 2016 +0100 Changed filename, changed user story. commit aa84ecb2ff6eae41e05ce5374e614c6e70c22db4 Author: Morten <[email protected]> Date: Fri Jan 15 14:42:47 2016 +0100 Added scenario for other users Other users shouldn't be allowed to add content to a public list FKB-14 commit 1791ef9fbeee836affbb380f0dd78803e519fe08 Author: Morten Bartvig <[email protected]> Date: Fri Jan 15 13:13:29 2016 +0100 Add javascript to make sure we don't run test before the page is loaded. FKB-14 commit e3698a124c70c92fb15b4cf0c4e237a31a9c3c62 Author: Morten Bartvig <[email protected]> Date: Fri Jan 15 12:58:34 2016 +0100 Changed selectors, added scrollTo in javascript. FKB-14 commit 88e07ffc1638581230be9138cb99ffe820b62b9e Author: Morten Bartvig <[email protected]> Date: Fri Jan 15 12:57:35 2016 +0100 Made test more robust by making it check all pages on the public list. FKB-29 commit 53f9de121e32ca4adda05450bdf9bda95ddbe8ce Author: Thomas Fini Hansen <[email protected]> Date: Fri Jan 15 10:52:04 2016 +0100 Clean up test a bit. commit db884e190e49c1e845fe9d59c4e856f211ec547e Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 15:52:51 2016 +0100 Only resize window when we're using Selenium. commit 2dd9e1b60f90c16276fa5d29b8516a82ca9acc07 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:14:32 2016 +0100 Changed behat test a little. We need more information than just searching for a tag, because the tag might not necessarily be on every material in the search result. FKB-27 commit 25de020da6306ed66bb64cf96356f1beca7ac1c8 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:03:36 2016 +0100 Added test code for unfollow tag. FKB-27 commit 74462a36af0168b466decd5945a43aba5da75dfa Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:02:45 2016 +0100 Fixed selectors and check checkbox instead of clicking link. FKB-28 FKB-27 commit 567d2beb9edf770d80a154756c998e78de07c693 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:01:42 2016 +0100 Removed wrong class name from css selector. commit 8ed8260901e2dcdb825bc325611b45e5adf5c82c Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 11:19:48 2016 +0100 Added test code for following tags. FKB-28 FKB-27 commit f1b91ad2d8a33c43be812fc6277a8bb90c8d8996 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 11:12:00 2016 +0100 Added tags, added unfollow. FKB-28 FKB-27 commit 4d77ade9954eb40bd27cd0b8a1f4c410d8c48c5b Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 10:38:58 2016 +0100 Behat tests for following tags. FKB-28. commit acf196ea30820a7b76e4a0206a143220bf7e1eb9 Merge: 16ee99386 bb7f99964 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:15:45 2016 +0100 Merge branch 'p2-tests' of github.com:reload/ding2 into p2-tests commit 16ee99386c3f35a32026abb8b1475acd45ebb06b Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 14:15:21 2016 +0100 Resize window to avoid problems with elements being invisible for the webdriver. commit bb7f999647a78e2b0c07029a169500783261926e Merge: 68e5715fd ca777b535 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 14 13:33:54 2016 +0100 Merge pull request #6 from reload/public-lists Public lists - make list public commit ca777b535b7dbeb2c00fdf4d04e1822b9cfcd1d7 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 11:23:46 2016 +0100 Added function for going to a list of a specific type. commit 65de42eb5f6da32d47d9840af12c7b4ef3af5db6 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 11:20:59 2016 +0100 Changed name of function. commit da6615a530dfee3399f7ca410757e2a18a650294 Merge: 68e5715fd 2370db28f Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 10:10:20 2016 +0100 Merge branch 'follow-author' into p2-tests commit 2370db28f1f6e952d0839755b05be8aec9b2357c Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 10:09:54 2016 +0100 Removed tag. commit 9006a3cb6cff1b270e5b2bb9d6020955158bae75 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 09:49:09 2016 +0100 Added steps for adding content to public lists. FKB-14 commit aad599368a539c7d4c6fb004e13599a1040eb2a2 Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 08:46:43 2016 +0100 Changed behat test to public lists. Changed wording to reflect that we want to add material to public lists. FKB-14 commit 28a879328ec113b0f697574a74badd6863e0b4cf Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 16:39:15 2016 +0100 Unfollow public lists. FKB-12. commit ce506d0625f4949c0fa801d9f7097d4c2f9ebff3 Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 16:38:55 2016 +0100 Use the function instead of fetching directly from the data registry. FKB-12. FKB-17. commit 572065e24ee5c3ae56413f2725eb8f6fa4b1256a Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 16:37:31 2016 +0100 Generalize iGoToTheList. So we can use it for more than user generated lists. FKB-12. FKB-17. commit 7d23bc670c55341f1dc52a854f6578489e909c04 Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 16:35:48 2016 +0100 Don't transform list name. Added checks for list. Only transform list name when we need it. Added checks for the list name existing in the data registry. FKB-12. FKB-17. commit cdfb5906111b0fa8bb0814c2fe1c3c2e5e8cf16c Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 16:33:23 2016 +0100 Changed title of public list. Changed title of public list to be different than the previous test. FKB-12. commit 417a6c45bfe7ba5eaab8cbaecd7d04a71d6c562b Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 15:45:40 2016 +0100 Follow a public list. Step definitions for following a public list. FKB-17. commit ff65fc2b7db3260905e3a86e13b4f27732de2538 Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 13:58:55 2016 +0100 Added step definitions for sharing public lists. FKB-29. commit ac5bc431a9de7fb77cf5b4afcb7faaf39ae61ef5 Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 13:57:07 2016 +0100 Added behat tests for public lists. FKB-12. FKB-14. FKB-17. FKB-29. commit 68e5715fd40341d5c5d4b12ed24acd9668173b04 Merge: def970ed2 5baf7d59d Author: Morten Bartvig <[email protected]> Date: Thu Jan 14 09:52:54 2016 +0100 Merge branch 'p2-tests' of github.com:reload/ding2 into p2-tests commit 5baf7d59dc3b41db3b25901f1480e30ec47b85ac Author: Thomas Fini Hansen <[email protected]> Date: Wed Jan 13 14:01:36 2016 +0100 Set up the test site. commit def970ed2ef4dd6f538276826117d934bd7b4d15 Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 14:00:49 2016 +0100 Added phantomjs-installer. commit a902eecc001b438f1861509bc86bae02a04652e2 Author: Thomas Fini Hansen <[email protected]> Date: Wed Jan 13 14:00:48 2016 +0100 Skip regression tests for the time being. commit 32e6fda5dfd1a0fc1098895d0ac29c175bcac8a0 Merge: e4b4c1fd1 c8c179186 Author: Morten <[email protected]> Date: Wed Jan 13 10:33:09 2016 +0100 Merge pull request #5 from reload/create-list-43 Test list creation. commit c8c17918656696899990ded1bef838e29f6dd9ce Author: Thomas Fini Hansen <[email protected]> Date: Wed Jan 13 10:26:22 2016 +0100 Test list creation. Closes FKB-43. commit e4b4c1fd11f1d97756708d4534677c68aae91380 Author: Thomas Fini Hansen <[email protected]> Date: Wed Jan 13 10:08:08 2016 +0100 Add profiles to run tests in Selenium. commit 83781935794001599cac85b5c106370802065d28 Merge: 5c22d24bc 9471d0d94 Author: Morten <[email protected]> Date: Wed Jan 13 10:01:06 2016 +0100 Merge pull request #3 from reload/follow-author Follow author commit 9471d0d945172bd3ee15b329fd8e02b722c307c7 Author: Morten Bartvig <[email protected]> Date: Wed Jan 13 09:58:56 2016 +0100 Indentation changes. commit 42334d2f8067daf49f08220bad9cd2332c4b7b50 Author: Morten Bartvig <[email protected]> Date: Tue Jan 12 10:17:44 2016 +0100 FKB-24. FKB-25. Changed indentation. commit 8e46422f91b2ff28980065f472521ef4f1a8412d Author: Morten Bartvig <[email protected]> Date: Tue Jan 12 10:17:24 2016 +0100 Moved data registry to P2Context. commit bece11a104b91ad94babd2bfb6df738b043d8f60 Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 08:58:59 2016 +0100 Moved code from Ding2Context to P2Context. Changed drupalContext and minkContext to public. commit 01a36219975962d7ee8b257a9a5c2a164b86de45 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 17:13:54 2016 +0100 Fixed conflict and added functions for following author. commit 09e05e98362165ac77a76801085d28fd11e35f8f Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 17:02:38 2016 +0100 Check if the list of followed searches exists and save the id in the data registry. commit 5c38f2bf76cd5d77a25a1ca1c343eb375d7c0320 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 17:01:01 2016 +0100 Added data registry for saving data across scenarios. commit 5c22d24bc7b289d1bd359dc4923570a635f06fb9 Merge: 3f3fe798f 767f3109e Author: Thomas Fini Hansen <[email protected]> Date: Wed Jan 13 08:23:01 2016 +0100 Merge pull request #4 from reload/follow-search Follow search commit 3f3fe798f2cb048d7a0231a4d24915052443335d Merge: 235cc3d1e ee294a4ca Author: Thomas Fini Hansen <[email protected]> Date: Wed Jan 13 08:21:54 2016 +0100 Merge pull request #2 from reload/user-consent FKB-31. Made test more defensive commit 235cc3d1e2c8f8a10b242aa39a7de2c6286e7515 Merge: d20750868 e149d8f6b Author: Morten <[email protected]> Date: Tue Jan 12 10:46:07 2016 +0100 Merge pull request #1 from reload/messages-check-fixup Clean up the messages check context. commit ee294a4ca25cb6ccb57731bf3ac8942dd0ffa631 Author: Morten Bartvig <[email protected]> Date: Tue Jan 12 10:23:43 2016 +0100 FKB-31. Made test more defensive, so that it checks if the user variable is correct, and that the checkbox exists. commit 767f3109eb77116f61c05ea80ad2e7587a3a5fd2 Author: Morten Bartvig <[email protected]> Date: Tue Jan 12 10:14:42 2016 +0100 FKB-21. FKB-22. Use wrapper function for fetching list id for user searches. Changed indentation a little. commit e149d8f6ba11eaf98a20cd90d573581fe4b2e2a3 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 12 10:08:14 2016 +0100 Clean up the messages check context. commit c3dd215c704f32a19ad42e1c803871771844ad4c Author: Morten Bartvig <[email protected]> Date: Tue Jan 12 09:39:45 2016 +0100 FKB-24. FKB-25. Added step definition for reading list id. Use this function where the list id is going to be used. commit ca0f73dca1d8bc7650520624b542878fac635a58 Author: Morten Bartvig <[email protected]> Date: Tue Jan 12 09:38:50 2016 +0100 FKB-24. FKB-25. Make test more defensive. commit d20750868ee942deea3e4fb0311b5be76fdb9a04 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 12 08:16:24 2016 +0100 Don't run @wip tests. commit 0ed82847392f12fa6d3ce6afa80a51a44a4db71d Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 12 08:15:21 2016 +0100 Suppress messages check for the moment being. commit 147d360665ba74c22914458d09767d4d0da91419 Merge: 8f69ac3ec 20675aecf Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 12 07:58:34 2016 +0100 Merge branch 'p2-tests' of github.com:reload/ding2 into p2-tests commit 20675aecfacee20af89b3dae504925829cf230d1 Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 15:45:28 2016 +0100 FKB-31. Added test for checking, that the consent checkbox is properly checked and unchecked. commit 969c5691ae4d4b6c52107ecbe21620cd965c0335 Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 15:44:03 2016 +0100 Removed tag. commit 8f69ac3ec7ee2cd0a4e29526da502920061b184d Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 11 14:22:46 2016 +0100 Ensure that no unexpected error messages is printed. commit d301209c3a0187524d28cbc9cf61683d91ea5e88 Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 14:05:29 2016 +0100 FKB-25. Changed When to Given. commit 9f9ec2771129e9b26f5cd9aede46c762e45a3bd9 Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 14:03:42 2016 +0100 FKB-21. FKB-22. Moved logging user in to Background and changed some givens/whens accordingly. Added test code. commit a0b5f1869d253aaa2027a9b40e88e0da49dff5ff Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 13:27:45 2016 +0100 FKB-24. FKB-25. Changed behat test for (un)following author. Moved logging in as library user to background. commit 12b9f03755813601201894572b24ce239ddc0d43 Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 13:26:54 2016 +0100 FKB-24. FKB-25. Added test code for (un)following author. commit bdbb9937d94fa84101148d159397e687c472b15c Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 13:25:04 2016 +0100 Moved using PendingException to P2Context. commit 6c6fff509670756ff5eab4ade89deb980fe46870 Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 09:55:36 2016 +0100 Removed iAmOn because it's ambigious and a function exists in minkContext. Changed iAmOnMyUserPage to use different function after previous removed function. commit 535eb016a0c797faa81ae31a5df6d9592d0471fc Author: Morten Bartvig <[email protected]> Date: Mon Jan 11 08:58:59 2016 +0100 Moved code from Ding2Context to P2Context. Changed drupalContext and minkContext to public. commit ef196e5bee93e5d2811d94e7c899dcac6ea48710 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 17:13:54 2016 +0100 Fixed conflict and added functions for following author. commit 19e1865c0d68c55b4e809fd005ab746289cf2f42 Merge: 535bbbd18 7aff0bb97 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 17:12:10 2016 +0100 Merge branch 'p2-tests' of github.com:reload/ding2 into p2-tests Conflicts: tests/features/bootstrap/Ding2Context.php commit 535bbbd18e1696310bfa363709fb14666a7a687d Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 17:04:46 2016 +0100 Added code for follow search behat tests. commit fc567f3d80c7c379a73e126a692a6c2db322ddb2 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 17:03:49 2016 +0100 Added checking for the list of followed searches and added @api tag. commit 6d689bc4c55e1fc42d512a28e765137b14225edb Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 17:02:38 2016 +0100 Check if the list of followed searches exists and save the id in the data registry. commit 3c58ac504948f8c650e3db1b3d24d3a64da01624 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 17:01:01 2016 +0100 Added data registry for saving data across scenarios. commit 2f4a5533f69d81e780fe7dd03af0a2fbd5dffb90 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 16:59:36 2016 +0100 Added mink context to class. commit c0254d406ba9019de97df1d9d3d9dee62fcf549d Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 16:58:44 2016 +0100 Added mink context to class. commit c2274d86886e290af28a6272264e8df2aca3e4fd Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 16:48:28 2016 +0100 Added namespace for PendingException. commit 7aff0bb9736a863fe0552ab84af9b2d35b6a7c50 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 7 14:44:35 2016 +0100 First passing scenario in materials list. commit 4d9881eb26fae3b4f32337a1a50a6e1db4612fd2 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 14:18:38 2016 +0100 FKB-24. FKB-25. Moved unfollow author feature to follow author feature and deleted file. commit 795b1c7be34babf815e7fcead1918b215631e81e Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 14:16:10 2016 +0100 FKB-21. FKB-22. Removed unfollow search feature and moved it into follow search. commit 0aa9eddb3bfa03dcf6afedfc5466f71b31aadce4 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 11:14:58 2016 +0100 FKB-25, FKB-24. Add Behat tests for follow and unfollow author. commit 0de98c42276d9e876519bc80bdeb81c22e717607 Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 11:14:26 2016 +0100 FKB-21. Add Behat test for unfollow search. commit 1537e4b18b49a8d29a99b7660c0fafaad599f03d Author: Morten Bartvig <[email protected]> Date: Thu Jan 7 11:13:26 2016 +0100 FKB-22. Added behat test for follow search. commit ba8827b303068b98b3d4326c237be9bfc6357a21 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 7 10:58:53 2016 +0100 Added material lists Behat feature. commit 7b2f540d095c16dccf11e2cb2d01cf3128504ee3 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 7 10:57:35 2016 +0100 Add library user login step definition. commit fcc7010f514f75ebe865cbec74cd30322be3d49c Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 7 10:55:43 2016 +0100 Setup P2 and test env on Circle. commit e4e1b4de712be6698817bc9e1436ab02cfd324c3 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 7 10:55:31 2016 +0100 Add P2 to make file. commit 73984a84b40c94e5165b439703dfc37f86fb4e58 Author: Thomas Fini Hansen <[email protected]> Date: Thu Jan 7 08:38:31 2016 +0100 Added user_consent provider to connie. commit 462c97a9c65f828c1cb5f488c3c3114a0efb1540 Author: Thomas Fini Hansen <[email protected]> Date: Wed Jan 6 14:36:10 2016 +0100 Issue #1562 by xendk: Updated connie feature. commit e2c090752e5fc6f280c208c10a7b40923a027474 Author: Thomas Fini Hansen <[email protected]> Date: Wed Jan 6 14:33:35 2016 +0100 Issue #1562 by xendk: Update connie so it works with latest ding2. commit 4b3f28ee38aeb6d2f9f8ed069a68357187608fb7 Author: Thomas Fini Hansen <[email protected]> Date: Wed Jan 6 14:27:28 2016 +0100 Issue #1562 by xendk: Make ding_user a bit more robust. commit b2e8f61c31461430ecd440610778b7570a778287 Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 4 21:33:23 2016 +0100 Make CircleCI display test results. commit c4411646bd17239f53727fc3ebf1bee7212fc940 Author: Thomas Fini Hansen <[email protected]> Date: Tue Jan 5 07:31:15 2016 +0100 Run behat with newer PHP version. commit 2ce43031df2ab21cee4f8a146a353af43f10e97d Author: Thomas Fini Hansen <[email protected]> Date: Mon Jan 4 17:45:29 2016 +0100 Initial behat/circle setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reviewed the code after #1.
The three commits included in this PR are suggestions for changes addressing some of the remaining problems. Be aware that I have not tested them in practice.