fix: Text.textContent setter #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-fuze
reviewed
Aug 9, 2024
src/dom/node.ts
Outdated
| @@ -635,6 +635,9 @@ export class Text extends CharacterData { | |||
| get textContent(): string { | |||
| return <string> this.nodeValue; | |||
| } | |||
| set textContent(value) { | |||
There was a problem hiding this comment.
Thanks for the PR. Can you put a line space between the two blocks and add a test?
There was a problem hiding this comment.
Actually, since Text extends CharacterData->Node and Node already implements getter/setter for textContent: Are you fine with removing both of them from Text?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One should be able to set
Text.textContent.