Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Container Apps Workload Profiled #1947 #1948

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

darrenhull
Copy link

@darrenhull darrenhull commented Mar 18, 2024

1947

PR Checklist


Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@darrenhull
Copy link
Author

Addresses #1947 by adding workload profiles to Container App Environments

@arnaudlh arnaudlh added this to the 5.7.11 milestone Mar 19, 2024
@darrenhull
Copy link
Author

@arnaudlh this PR now contains a breaking change because there is a breaking change in version 3.82.0 of terraform-provider-azurerm

How should it be handled?

@arnaudlh arnaudlh modified the milestones: 5.7.11, 5.7.12 May 4, 2024
@arnaudlh arnaudlh linked an issue May 27, 2024 that may be closed by this pull request
1 task
@arnaudlh arnaudlh added the enhancement New feature or request label May 27, 2024
@arnaudlh arnaudlh self-requested a review June 3, 2024 15:37
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @darrenhull thanks for the PR, you can see from the pipeline run here, there are a couple of things to address: https://github.com/aztfmod/terraform-azurerm-caf/actions/runs/9353085218/job/25744923700

@@ -83,6 +83,12 @@ container_app_environments = {
}
internal_load_balancer_enabled = true
zone_redundancy_enabled = true
workload_profile {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
workload_profile {
workload_profile = {

Copy link
Author

@darrenhull darrenhull Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i didnt get a notification on this i will update it, i think i have a newer version on my fork.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated this now @arnaudlh is there any documentation on how to run the tests locally?

@arnaudlh arnaudlh removed this from the 5.7.12 milestone Jun 3, 2024
@Mohamed-Ltaief
Copy link

Mohamed-Ltaief commented Jun 12, 2024

👍 We need this feature

@darrenhull
Copy link
Author

darrenhull commented Jun 26, 2024

👍 We need this feature

its working on my forked dev branch if you need it before its pulled in.

@darrenhull darrenhull requested a review from arnaudlh June 27, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Add workload profile to Container App Environment
3 participants