-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Container Apps Workload Profiled #1947 #1948
base: main
Are you sure you want to change the base?
Added Container Apps Workload Profiled #1947 #1948
Conversation
Addresses #1947 by adding workload profiles to Container App Environments |
@arnaudlh this PR now contains a breaking change because there is a breaking change in version 3.82.0 of terraform-provider-azurerm How should it be handled? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @darrenhull thanks for the PR, you can see from the pipeline run here, there are a couple of things to address: https://github.com/aztfmod/terraform-azurerm-caf/actions/runs/9353085218/job/25744923700
@@ -83,6 +83,12 @@ container_app_environments = { | |||
} | |||
internal_load_balancer_enabled = true | |||
zone_redundancy_enabled = true | |||
workload_profile { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workload_profile { | |
workload_profile = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i didnt get a notification on this i will update it, i think i have a newer version on my fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this now @arnaudlh is there any documentation on how to run the tests locally?
👍 We need this feature |
its working on my forked dev branch if you need it before its pulled in. |
1947
PR Checklist
Description
Does this introduce a breaking change
Testing