Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added different message to distinguish between two cases: #495

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

zerkms
Copy link
Contributor

@zerkms zerkms commented Sep 25, 2024

a) the value at the path is of the wrong type
b) the path does not exist

Fixes #494

IMPORTANT: this is still "work-in-progress" and merely a conversation opener with the aim to find out better wording (not sure I like it like that, but it's the best I could think of at the moment).

@coveralls
Copy link

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11025356195

Details

  • 30 of 30 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 98.695%

Totals Coverage Status
Change from base Build 10847576320: 0.004%
Covered Lines: 5371
Relevant Lines: 5442

💛 - Coveralls

a) the value at the path is of the wrong type
b) the path does not exist

.
@zerkms zerkms force-pushed the 494-lack-of-key-error-message branch from 40639a4 to 93af1e7 Compare September 25, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New v3 path error message should distinguish between "lack of key" and "key equals null"
2 participants