Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Scripts/BlackTemple): exclude off tank of the Azzinoth Flame's charge #20133

Merged
merged 3 commits into from
Oct 5, 2024

Conversation

Grimdhex
Copy link
Contributor

@Grimdhex Grimdhex commented Oct 4, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1..tele bt
2. .go creature id 22917
3. going to fase 2 (under 65% hp)
4. place the flames of azzinoth on the warglaives launched by illidan. obviously you need 2 characters to do this.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added Script file-cpp Used to trigger the matrix build labels Oct 4, 2024
@Rorschach91
Copy link

Rorschach91 commented Oct 4, 2024

I could be right to the idea of exclude tanks from the charge mechanics (expecially after reading WoWHead guide) but I continue to think that charge range should be increased.
Watching some videos i have noted that charge range on tbc classic is not the same on AzerothCore.
For this reason I tested the phase with 45 yard 2 days ago.
In any case I would like to read the opinion of the others.

@Grimdhex
Copy link
Contributor Author

Grimdhex commented Oct 5, 2024

Does 45y works as what you seen on videos ?

@elthehablo
Copy link
Contributor

Let's include that in another PR if needed/confirmed

@elthehablo elthehablo merged commit 508b736 into azerothcore:master Oct 5, 2024
13 checks passed
@Rorschach91
Copy link

Lol, I was testing it.

@elthehablo
Copy link
Contributor

That's good. However looking at the code it should work and cause no additional issues.

By all means still test it though.

@Grimdhex Grimdhex deleted the fix_flames_charges branch October 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-cpp Used to trigger the matrix build Script
Projects
None yet
3 participants