This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Bump to components 0.2.8 #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i was having trouble running into this on staging too. can you remind me of a combination that produced the error in the first place? :/ |
|
It would happen occasionally when loading indicator charts. |
fungjj92
approved these changes
Jan 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Bumps components library, which incorporates fixes for #349
Demo
Should no longer see error present in #349 when viewing indicator charts
Notes
Components 0.2.6 and 0.2.7 are buggy releases due to our testing process for the library being subpar. We'll need to address the testing difficulties if we choose to do any more work on this library. Issues noted in the components CHANGELOG with notes to prefer 0.2.8
Testing Instructions
./scripts/update && ./scripts/server, then view an indicator chart on the indicator page, tweaking a bunch of different model paramsCloses #349