This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Add historic range control #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add form for setting historic range, for the two indicators that have only historic range as an extra parameter. Closes azavea#203.
To discover the available historic ranges.
flibbertigibbet
force-pushed
the
feature/kak/historic-range-controls#203
branch
from
3cc4367 to
9dcaa51
Compare
Switch to using drop-down with available historic range start dates.
Since historic range is an optional extra parameter, add empty option to drop-down.
CloudNiner
approved these changes
Sep 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add form for setting historic range, for the two indicators that have only historic range as an extra parameter.
Demo
Notes
It would be better to present the available options as a drop-down, as there are only three base years available, by querying for the options from/api/historic-range/. As it is, this text field needs a way to give error feedback, as does #230.Updated to query for options and use them in a drop-down. One of the options is empty, as this parameter is not required.
Testing Instructions
Closes #203.