Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Add form validation feedback #243

Open
flibbertigibbet opened this issue Sep 5, 2017 · 8 comments
Open

Add form validation feedback #243

flibbertigibbet opened this issue Sep 5, 2017 · 8 comments
Labels

Comments

@flibbertigibbet
Copy link
Contributor

If a user enters invalid data in a parameters control form, the chart simply fails to reload.

Provide feedback, either as text or with a red border to the form control, or both, so the user may see that the form is invalid.

See #230.

@jfrankl
Copy link
Contributor

jfrankl commented Sep 11, 2017

@flibbertigibbet I am trying to understand this issue better. Could you give me 2–3 examples of invalid input? For each:

  • Name of indicator
  • Expected input range
  • Input that would trigger an error

@flibbertigibbet
Copy link
Contributor Author

As with #230:

  • percentile low temperature
  • integers range 0 to 100
  • numbers typed in outside of range or with a decimal point component

@jfrankl
Copy link
Contributor

jfrankl commented Sep 11, 2017

Does something like this work?

image

@fungjj92
Copy link
Contributor

fungjj92 commented Sep 12, 2017

I think that's a great visual

@CloudNiner
Copy link

Does the red error text fill existing empty space, such that all the components below it don't shift down when the error displays? Otherwise agreed, looks great.

@jfrankl
Copy link
Contributor

jfrankl commented Sep 12, 2017

@CloudNiner What do you think of something like this, so we don't need to worry about the error message pushing down other content?

image

@CloudNiner
Copy link

That seems good too, as long as the white text on red is readable. It feels very thin but that may just be the screenshot.

@maurizi
Copy link
Contributor

maurizi commented Mar 1, 2019

Styling for error popovers was added in #342, but we should still add validation to the rest of the controls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants