Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Project add/edit form is not a form #266

Closed
flibbertigibbet opened this issue Sep 25, 2017 · 1 comment
Closed

Project add/edit form is not a form #266

flibbertigibbet opened this issue Sep 25, 2017 · 1 comment

Comments

@flibbertigibbet
Copy link
Contributor

The page to add or edit a project is not a proper Angular form, and so cannot use model change detection.

Implementing OnChanges for AddEditProjectComponent has no effect (no changes detected).

Defining ngModel and name for the form so changes may be detected results in the error:

No value accessor for form control with name: ...

@flibbertigibbet
Copy link
Contributor Author

Making the page a proper form may be necessary for validation (see #243).

@maurizi maurizi self-assigned this Feb 22, 2019
maurizi added a commit that referenced this issue Feb 28, 2019
Rather than using the city endpoint for the autocomplete in the new project
form and the lab header, we now use a Google geocoder, and make a separate AJAX
call to the API to determine if that lat/lon has data.

This will allow us to support a broader number of locations than we do
currently.

Closes #333
Closes #266
Closes #251
maurizi added a commit that referenced this issue Mar 1, 2019
Rather than using the city endpoint for the autocomplete in the new project
form and the lab header, we now use a Google geocoder, and make a separate AJAX
call to the API to determine if that lat/lon has data.

This will allow us to support a broader number of locations than we do
currently.

Closes #333
Closes #266
Closes #251
maurizi added a commit that referenced this issue Mar 1, 2019
Rather than using the city endpoint for the autocomplete in the new project
form and the lab header, we now use a Google geocoder, and make a separate AJAX
call to the API to determine if that lat/lon has data.

This will allow us to support a broader number of locations than we do
currently.

Closes #333
Closes #266
Closes #251
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants