-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Detect storage_system_stack_trace_pipe_read_timeout_ms (compatibily f…
…or <23.5) This storage_system_stack_trace_pipe_read_timeout_ms used for live flamegraph feature, that shows live thread stack traces from system.stack_trace. The setting itself useful to increase the probability that the stacktrace will be captured and failed due to timeout.
- Loading branch information
Showing
3 changed files
with
64 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
use semver::{Version, VersionReq}; | ||
|
||
#[allow(non_camel_case_types)] | ||
#[derive(Debug, Clone, Copy)] | ||
pub enum ClickHouseCompatibilitySettings { | ||
storage_system_stack_trace_pipe_read_timeout_ms = 1, | ||
} | ||
|
||
const SETTINGS: [(&str, ClickHouseCompatibilitySettings); 1] = [( | ||
">=23.5", | ||
ClickHouseCompatibilitySettings::storage_system_stack_trace_pipe_read_timeout_ms, | ||
)]; | ||
|
||
pub struct ClickHouseCompatibility { | ||
mask: u64, | ||
} | ||
|
||
impl ClickHouseCompatibility { | ||
pub fn new(version_string: String) -> Self { | ||
// Version::parse() supports only x.y.z and nothing more. | ||
let ver_maj_min_patch = version_string.split('.').collect::<Vec<&str>>()[0..3].join("."); | ||
log::debug!("Version (maj.min.patch): {}", ver_maj_min_patch); | ||
|
||
let version = Version::parse(ver_maj_min_patch.as_str()) | ||
.expect(&format!("Cannot parse version: {}", ver_maj_min_patch)); | ||
let mut mask: u64 = 0; | ||
|
||
for setting in &SETTINGS { | ||
let version_requirement = VersionReq::parse(setting.0).expect(&format!( | ||
"Cannot parse version requirements for {:?}", | ||
setting.1 | ||
)); | ||
if version_requirement.matches(&version) { | ||
mask |= setting.1 as u64; | ||
log::warn!("Apply setting {:?}", setting.1); | ||
} | ||
} | ||
|
||
return Self { mask }; | ||
} | ||
|
||
pub fn has(&self, setting: ClickHouseCompatibilitySettings) -> bool { | ||
return (self.mask & setting as u64) != 0; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters