Skip to content

Commit

Permalink
397 (#399)
Browse files Browse the repository at this point in the history
* initial attempt

* initial attempt

* fixes #397

* fixes #397

* fix preview appearing on wrong pages on move

* vers bump
  • Loading branch information
aza547 authored May 3, 2023
1 parent f3855e0 commit d57501f
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 4 deletions.
5 changes: 4 additions & 1 deletion docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased
### Fixed
### Added
### Changed

## [3.12.0] - 2023-05-03
### Added
- [Issue 386](https://github.com/aza547/wow-recorder/issues/386) - Option to disable minimize to tray.
- [Issue 394](https://github.com/aza547/wow-recorder/issues/394) - Updates for Dragonflight season 2 content.

### Changed
### Fixed
- [Issue 397](https://github.com/aza547/wow-recorder/issues/397) - Fix issue where scene preview may not position correctly.

Expand Down
2 changes: 1 addition & 1 deletion release/app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "WarcraftRecorder",
"version": "3.11.0",
"version": "3.12.0",
"description": "A World of Warcraft screen recorder",
"main": "./dist/main/main.js",
"author": {
Expand Down
16 changes: 14 additions & 2 deletions src/main/Recorder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,12 @@ export default class Recorder {
/**
* Exists across a reconfigure.
*/
private previewLocation: TPreviewPosition | undefined;
private previewLocation: TPreviewPosition = {
width: 0,
height: 0,
xPos: 0,
yPos: 0,
};

/**
* The image source to be used for the overlay, we create this
Expand Down Expand Up @@ -1212,7 +1217,14 @@ export default class Recorder {

// I'd love to make OBS_content_destroyDisplay work here but I've not managed
// so far. This is a hack to "hide" it by moving it off screen.
osn.NodeObs.OBS_content_moveDisplay(this.previewName, 50000, 50000);
this.previewLocation.xPos = 50000;
this.previewLocation.yPos = 50000;

osn.NodeObs.OBS_content_moveDisplay(
this.previewName,
this.previewLocation.xPos,
this.previewLocation.yPos
);
}

/**
Expand Down

0 comments on commit d57501f

Please sign in to comment.