Skip to content

Commit

Permalink
installer fix (#379)
Browse files Browse the repository at this point in the history
  • Loading branch information
aza547 authored Apr 24, 2023
1 parent 2b70262 commit 980a5af
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 1 deletion.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,9 @@ I've created a dedicated discord for this project, feel free to join [here](http
# Contributing

If you're interested in getting involved please drop me a message on discord and I can give you access to our development channel. Also see [contributing](https://github.com/aza547/wow-recorder/blob/main/docs/CONTRIBUTING.md) docs.

# Mentions

The recording done by Warcraft Recorder is made possible by packaging up [OBS](https://obsproject.com/). We wouldn't stand a chance at providing something useful without it. Big thanks to the OBS developers.

This application is also heavily reliant on the [OBS Studio Node Packge](https://github.com/stream-labs/obs-studio-node) to provide bindings to libOBS. Special mention for the folks over at [Streamlabs](https://streamlabs.com/) for open-sourcing the project.
4 changes: 4 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
### Fixed

## [3.10.3] - 2023-04-24
### Fixed
- [Issue 328](https://github.com/aza547/wow-recorder/issues/328) - Fix a bug where the installer didn't automatically install the Visual C++ Redistributable package from Microsoft.

## [3.10.2] - 2023-04-23
### Changed
- [Issue 370](https://github.com/aza547/wow-recorder/issues/370) - Show more than the most recent video on home page.
Expand Down
24 changes: 24 additions & 0 deletions installer.nsh
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
!macro customInstall
NSISdl::download https://aka.ms/vs/17/release/vc_redist.x64.exe "$INSTDIR\vc_redist.x64.exe"

${If} ${FileExists} `$INSTDIR\vc_redist.x64.exe`
ExecWait '$INSTDIR\vc_redist.x64.exe /passive /norestart' $1

${If} $1 != '0'
${If} $1 != '3010'
MessageBox MB_OK|MB_ICONEXCLAMATION 'WARNING: Warcraft Recorder was unable to install the latest Visual C++ Redistributable package from Microsoft.'
${EndIf}
${EndIf}

# ${If} $1 == '3010'
# MessageBox MB_OK|MB_ICONEXCLAMATION 'You must restart your computer to complete the installation.'
# ${EndIf}

${Else}
MessageBox MB_OK|MB_ICONEXCLAMATION 'WARNING: Warcraft Recorder was unable to download the latest Visual C++ Redistributable package from Microsoft.'
${EndIf}

FileOpen $0 "$INSTDIR\installername" w
FileWrite $0 $EXEFILE
FileClose $0
!macroend
6 changes: 6 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@
}
]
},
"nsis": {
"oneClick": false,
"allowToChangeInstallationDirectory": true,
"include": "installer.nsh",
"deleteAppDataOnUninstall": true
},
"win": {
"target": [
"nsis"
Expand Down
2 changes: 1 addition & 1 deletion release/app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "WarcraftRecorder",
"version": "3.10.2",
"version": "3.10.3",
"description": "A World of Warcraft screen recorder",
"main": "./dist/main/main.js",
"author": {
Expand Down

0 comments on commit 980a5af

Please sign in to comment.