Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3823 Card Widget Deprecation Notices #3864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Nov 5, 2024

Description

Generation of Card widget previews currently does not check if the URL is set before using it. This PR updates the check to verify if the value is present.

Related issues

#3823

How to test

  • Enable az_demo
  • Visit a node which contains cards, such as /pages/card-decks, or create a new page.
  • Edit (or add) a card deck
  • Create a card which has a link title, but no link URL.
  • Save the page
  • Edit the page
  • Reopen the card deck
  • Open and Collapse the individual card several times
  • Check /admin/reports/dblog
  • Verify that Deprecated function: str_starts_with(): Passing null to parameter #1 ($haystack) of type string is deprecated is not being generated
  • Check for any regressions in card preview functionality
  • Verify that a Card Link URL to a public file still works correctly, e.g. /sites/default/files/placeduck01.jpg

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@tadean tadean added bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites labels Nov 5, 2024
@tadean tadean self-assigned this Nov 5, 2024
@tadean tadean requested a review from a team as a code owner November 5, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites
Projects
Status: To triage
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant