-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rlp decode of SignedTransction
with interoperation signature
#1533
Conversation
6163ccd
to
de3c4ae
Compare
If there is a bugfix, please split the bugfix and the refactor into two PRs, at least two commits. As an answer of the #1514, base on this PR, I don't understand whether that issue is confirmed or not. |
9beaf3c
to
febdc75
Compare
They are divided into two commits. |
SignedTransction
with interoperation signature
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
febdc75
to
befcbb9
Compare
befcbb9
to
c91a6af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except the following line:
axon/protocol/src/types/transaction.rs
Line 466 in c91a6af
public: Some(Public::zero()), |
- Is it security?
- Why it's not just a
None
?
It's not easy for me to assess it right now.
So I just mark it, let's merge this PR first, then I will spend time to assess it later when I free.
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
ReminderIn order to preserve the commit history, please do NOT use merge_quere or squash merge for this PR. |
What this PR does / why we need it?
This PR:
Original
a. When the transaction is from API, the sender address is recovery by the interoperation logic
b. When the transaction if from network and insert into mempool directly, the sender address is recovery by rlp decode. However, the rlp decode logic is different from the interoperation.
Current
The rlp decode logic is same as interoperation logic.
verify_by_ckb_vm
verification code due to the schedule.What is the impact of this PR?
No Breaking Change
PR relation:
sender
for a transaction with CKB-VM mode is incorrect. #1514CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description