fix(test): check genesis before it completed #1466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
The test for genesis block initialization was broken since #1454.
It moved some updates of header behind the check of the genesis hash.
The genesis hash is checked in line 132.
axon/core/run/src/tests.rs
Lines 132 to 137 in 5b2310c
But correct receipts root is computed later in line 170, and it is never set back to the genesis.
axon/core/run/src/tests.rs
Lines 176 to 179 in 5b2310c
axon/core/run/src/tests.rs
Lines 181 to 183 in 5b2310c
Also, it copied some code into tests, so the real code won't be tested.
The real code which requires tests:
axon/core/run/src/lib.rs
Lines 450 to 461 in 5b2310c
The code copied into tests.
axon/core/run/src/tests.rs
Lines 168 to 175 in 5b2310c
What is the impact of this PR?
No Breaking Change
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description