Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first hardfork with contract size limit #1451

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

driftluo
Copy link
Contributor

@driftluo driftluo commented Sep 26, 2023

What this PR does / why we need it?

This PR brings the first hardfork version of the axon. If this hardfork is activated, users can modify the EVM contract size limit.

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@driftluo driftluo requested a review from KaoImin September 26, 2023 08:09
@KaoImin KaoImin changed the title feat: first hardfork with contract limit feat: first hardfork with contract size limit Sep 26, 2023
@driftluo driftluo force-pushed the first-hardfork-with-contract-limit branch from 7539a75 to 0590bf9 Compare September 26, 2023 08:34
@driftluo driftluo force-pushed the first-hardfork-with-contract-limit branch from 0590bf9 to 344fe85 Compare September 26, 2023 08:59
@Flouse

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@KaoImin

This comment was marked as outdated.

@Flouse Flouse changed the base branch from main to remove-genesis-transaction September 28, 2023 08:52
@KaoImin KaoImin force-pushed the remove-genesis-transaction branch from f000c0f to 1df6ee1 Compare October 7, 2023 01:56
protocol/src/types/block.rs Outdated Show resolved Hide resolved
@KaoImin KaoImin force-pushed the remove-genesis-transaction branch from dacb972 to 7d73ca2 Compare October 9, 2023 04:14
@KaoImin

This comment was marked as outdated.

@driftluo driftluo force-pushed the first-hardfork-with-contract-limit branch from 2dad8d8 to a444455 Compare October 10, 2023 04:38
@driftluo driftluo changed the base branch from remove-genesis-transaction to main October 10, 2023 04:39
@KaoImin KaoImin force-pushed the first-hardfork-with-contract-limit branch from c586a18 to 25d85ac Compare October 10, 2023 08:44
@KaoImin
Copy link
Contributor

KaoImin commented Oct 10, 2023

if block_number.is_zero() {
return;
}

Missing apply the changes to DB here. It should be like this:

		if block_number.is_zero() {
		    let changes = generate_mpt_root_changes(adapter, Self::ADDRESS);
		    adapter.apply(changes, vec![], false);
		    return;
		}

Because of my commit insert the genesis hardfork information directly. No need to do apply in after hook. If the block number is zero, the after block hook of metadata system contract will return directly.

@driftluo driftluo force-pushed the first-hardfork-with-contract-limit branch from a813760 to 1211020 Compare October 10, 2023 10:23
@driftluo driftluo marked this pull request as ready for review October 10, 2023 10:41
@driftluo driftluo requested a review from a team as a code owner October 10, 2023 10:41
@driftluo driftluo force-pushed the first-hardfork-with-contract-limit branch from 1211020 to e4ec631 Compare October 11, 2023 03:22
@Flouse

This comment was marked as off-topic.

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@Flouse Flouse added the P-High label Oct 11, 2023
Flouse
Flouse previously approved these changes Oct 11, 2023
common/config-parser/src/types/spec.rs Show resolved Hide resolved
@KaoImin KaoImin changed the title feat: first hardfork with contract size limit [WIP wait for #14471] feat: first hardfork with contract size limit Oct 11, 2023
@KaoImin KaoImin changed the title [WIP wait for #14471] feat: first hardfork with contract size limit [WIP wait for #1471] feat: first hardfork with contract size limit Oct 11, 2023
protocol/src/types/primitive.rs Outdated Show resolved Hide resolved
protocol/src/types/block.rs Outdated Show resolved Hide resolved
@KaoImin KaoImin changed the title [WIP wait for #1471] feat: first hardfork with contract size limit feat: first hardfork with contract size limit Oct 12, 2023
@driftluo driftluo dismissed stale reviews from yangby-cryptape, KaoImin, and Flouse via 351bb17 October 12, 2023 04:10
@driftluo driftluo force-pushed the first-hardfork-with-contract-limit branch from e4ec631 to 351bb17 Compare October 12, 2023 04:10
KaoImin
KaoImin previously approved these changes Oct 12, 2023
@driftluo driftluo force-pushed the first-hardfork-with-contract-limit branch from 351bb17 to e748eaa Compare October 12, 2023 04:25
@KaoImin KaoImin enabled auto-merge October 12, 2023 04:27
@KaoImin KaoImin added this pull request to the merge queue Oct 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 12, 2023
@driftluo driftluo added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 3cddf14 Oct 12, 2023
17 checks passed
@driftluo driftluo deleted the first-hardfork-with-contract-limit branch October 12, 2023 07:21
@Flouse Flouse added t:feature and removed feature labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants