refactor: change metadata system contract and add annotation (#1449)

* style: change some code style and annotation * add some annotation * Update comments in builtin-contract/metadata/contracts/metadata.sol * refactor solidity contract to interface * remove useless code * add some annotation * update gh workflow * update some annotation * fix unit test * refactor chain-spec.toml * fix some typo * chore: rm metadata-test in Makefile --------- Co-authored-by: Flouse <[email protected]>
axonweb3 · Oct 9, 2023 · 2dd3e88 · 2dd3e88
1 parent 60fcec3
commit 2dd3e88
Show file tree

Hide file tree

Showing 35 changed files with 241 additions and 5,243 deletions.
diff --git a/.github/workflows/unit_test.yml b/.github/workflows/unit_test.yml
@@ -36,7 +36,7 @@ jobs:
           ~/.cargo/git/db/
           target/
         key: ${{ matrix.os }}-${{ runner.os }}-${{ runner.arch }}-cargo-test-${{ hashFiles('**/Cargo.lock') }}
-  
+
     - name: Run Rust unit-test
       run: make test
 
@@ -45,7 +45,5 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - uses: actions/setup-node@v3
-    - name: Run metadata-test
-      run: make metadata-test
     - name: Run crosschain-test
       run: make crosschain-test
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Makefile b/Makefile
@@ -79,21 +79,14 @@ security-audit:
 	@cargo audit --version || cargo install cargo-audit
 	@cargo audit
 
-metadata-test:
-	cd builtin-contract/metadata \
-		&& yarn --from-lock-file && yarn run compile && yarn run test
-
-metadata-genesis-deploy:
-	cd builtin-contract/metadata && yarn run deploy
-
 crosschain-test:
 	cd builtin-contract/crosschain \
 		&& yarn --from-lock-file && yarn run compile && yarn run test
 
 crosschain-genesis-deploy:
 	cd builtin-contract/crosschain && yarn run deploy
 
-unit-test: test metadata-test crosschain-test
+unit-test: test crosschain-test
 
 schema:
 	make -C core/cross-client/ schema

diff --git a/builtin-contract/metadata/.gitignore b/builtin-contract/metadata/.gitignore
diff --git a/builtin-contract/metadata/contracts/metadata.sol b/builtin-contract/metadata/contracts/metadata.sol
diff --git a/builtin-contract/metadata/hardhat.config.js b/builtin-contract/metadata/hardhat.config.js
diff --git a/builtin-contract/metadata/package.json b/builtin-contract/metadata/package.json
diff --git a/builtin-contract/metadata/scripts/metadata.deploy.js b/builtin-contract/metadata/scripts/metadata.deploy.js
diff --git a/builtin-contract/metadata/scripts/metadata.proxy.js b/builtin-contract/metadata/scripts/metadata.proxy.js