Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've struggled lately with fixing the package.lock after updates.
The main problem was that our editor dependencies were moved from "node_modules/...editor" to "extension/node_modules/...editor". After such a change the build was failing as the dependencies were no longer be found.
It took me some time to realize what the problem was, as nether the root or the extension has a dependency to any editors.
I think the problem is the npm has problems when you have packages in other packages:
As it then don't hoist dependencies up to the root node_modules but to the next upper level, in this case extension.
I think we don't need to have the webview code inside the extension, only the built output. So I moved the webviews folder to the root directory.
The output of the build step is still inside the extension itself "extension/dist/webviews", so everything should still work as expected