Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build #382

wants to merge 1 commit into from

Conversation

ivy-lli
Copy link
Member

@ivy-lli ivy-lli commented Jan 24, 2025

I've struggled lately with fixing the package.lock after updates.
The main problem was that our editor dependencies were moved from "node_modules/...editor" to "extension/node_modules/...editor". After such a change the build was failing as the dependencies were no longer be found.

It took me some time to realize what the problem was, as nether the root or the extension has a dependency to any editors.
I think the problem is the npm has problems when you have packages in other packages:

  • root
    • extension
      • webviews/...
        As it then don't hoist dependencies up to the root node_modules but to the next upper level, in this case extension.

I think we don't need to have the webview code inside the extension, only the built output. So I moved the webviews folder to the root directory.
The output of the build step is still inside the extension itself "extension/dist/webviews", so everything should still work as expected

Copy link
Member

@ivy-lmu ivy-lmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants