Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright #41

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Playwright #41

merged 3 commits into from
Jan 11, 2024

Conversation

ivy-rew
Copy link
Member

@ivy-rew ivy-rew commented Jan 10, 2024

No description provided.

@ivy-rew ivy-rew force-pushed the playwright branch 5 times, most recently from 729d8c0 to 1d01de4 Compare January 11, 2024 07:59
@ivy-rew ivy-rew force-pushed the playwright branch 8 times, most recently from 9bc61e9 to 463df5c Compare January 11, 2024 09:04
Comment on lines +3 to +8
test('swagger ui renderer', async ({ page }) => {
await page.goto('/');

await expect(page).toHaveTitle(/API Browser/);
await expect(page.getByText('Authorize')).toBeVisible();
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a simple minimal test for swagger-ui-ivy ... in order to get fast feedback on braking changes supplied by dependabot updates

@ivy-rew ivy-rew requested a review from ivy-lli January 11, 2024 09:13
@ivy-rew ivy-rew marked this pull request as ready for review January 11, 2024 09:13
Copy link
Member

@ivy-lli ivy-lli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@@ -0,0 +1 @@
18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a hint for the 'nvm' binary ... with this I can go into this repo and execute nvm use ... and the version given in this .nvmrc will automatically installed and enabled.

.gitignore Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
@ivy-rew ivy-rew merged commit 88ceb1c into master Jan 11, 2024
2 checks passed
@ivy-rew ivy-rew deleted the playwright branch January 11, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants