-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy github site using maven-scm-publish plugin 🏗️ #532
Conversation
ba72267
to
d84ae6f
Compare
eced40d
to
bb27559
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something like this looks easier:
https://www.lorenzobettini.it/2020/01/publishing-a-maven-site-to-github-pages/
definitively promising, thanks for sharing. I'll try this approach. |
bb27559
to
b8524bf
Compare
booleanParam(name: 'skipGitHubSite', | ||
description: 'If checked the plugin documentation on GitHub will NOT be updated', | ||
defaultValue: true) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one of the reasons why the release pipeline tends to fail: ... we did not automatically run github sites creation (due to its slow runtime with egit).
Now we will update the snapshot docs on every nightly, which is what we want I think
git config --global user.name 'ivy-team' | ||
git config --global user.email '[email protected]' | ||
""" | ||
maven cmd: "site site:stage scm-publish:publish-scm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci: also generates the site ... just before deploying
@@ -41,6 +41,8 @@ pipeline { | |||
sh "gh auth login --with-token < ${tokenFile}" | |||
sh "gh pr create --title '${message}' --body '${message}' --head ${targetBranch} --base ${env.BRANCH_NAME}" | |||
} | |||
// publish site from 'mvn release' run | |||
maven cmd: "site:stage scm-publish:publish-scm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no site generation (would be in wrong mode -> next snapshot).
I think the generated site from release-profile should still exist and be re-usable for publishing (but hard to test without actually running a release :)
@@ -349,7 +333,7 @@ | |||
<configuration> | |||
<tagNameFormat>v@{project.version}</tagNameFormat> | |||
<releaseProfiles>release</releaseProfiles> | |||
<goals>deploy site-deploy</goals> | |||
<goals>deploy site</goals> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the actual xhtml generation when running a release.
here's a sample site publish commit: provided by scm-publish:publish-scm (though run on my local cli) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better 👍
b8524bf
to
aa746d2
Compare
first approach that works without e-git; here to gather (your 😉 ) early feedback @alexsuter