Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use java nio instead of io #469

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Use java nio instead of io #469

merged 2 commits into from
Jul 23, 2024

Conversation

alexsuter
Copy link
Member

@alexsuter alexsuter commented Jul 22, 2024 •
edited
Loading

It's now possible to inject Path instead of File in a Mojo. I use now everywhere Path.
Next step, I will try to get rid of commons-io dependency.

@alexsuter alexsuter force-pushed the java-nio-rocket branch 5 times, most recently from 422df50 to 8d81b94 Compare July 22, 2024 15:53
@alexsuter alexsuter requested a review from ivy-rew July 22, 2024 15:54
ivy-rew
ivy-rew approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@ivy-rew ivy-rew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, did some investigation .... but to big change for detailed analysis -> gonna trust your work :)

@alexsuter alexsuter merged commit 59cb1b5 into master Jul 23, 2024
6 checks passed
@alexsuter alexsuter deleted the java-nio-rocket branch July 23, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivy-rew ivy-rew ivy-rew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsuter @ivy-rew