XIVY-9730 Load jvm-module.options from bin/jvm-module.options with backward compatiblity support #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckward compatiblity support
alexsuter
commented
Jun 14, 2024
| return Collections.emptyList(); | ||
| var jvmOptionsFile = engineDir.toPath().resolve("bin").resolve("jvm-module.options"); | ||
| if (!Files.exists(jvmOptionsFile)) { | ||
| // Fallback: It was placed in another place in Axon Ivy Engine before 11.4.0 |
There was a problem hiding this comment.
since we don't support (I guess) to use a newer project build plugin to be compatible with an older engine, we don't need this fallback.
If you like I can remove it, when all builds have been properly integrated?
There was a problem hiding this comment.
yes, I'd remove it after integrating..
ivy-rew
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.