Add optional module for performance measurements #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tortmayr
commented
Sep 9, 2024
tortmayr
commented
- Introduce an optional performance module that add performance measurements to core GLSP concepts.
- Performance is simply measured using console.time which also allows inspection of the tracked events in the dev tools trace viewer
- The module is opt-in and disabled by default. To enable it the &performance=true query parameter has to be added to the url
tortmayr
force-pushed
the
perf-improv
branch
from
298a8a1 to
4751b8e
Compare
- Introduce an optional performance module that add performance measurements to core GLSP concepts. - Performance is simply measured using console.time which also allows inspection of the tracked events in the dev tools trace viewer - The module is opt-in and disabled by default. To enable it the &performance=true query parameter has to be added to the url
Measure actions when they are actually handled instead of on dispatch (avoids inconsistencies due to action queue blocking) Add in depth logging for set-model-command and model update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.