Feature/xivy 12667 UI #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabled test as mocking is not implemented
removed linebreak
…tion Feature/xivy 12667 optimization
# Please enter the commit message for your changes. Lines starting
XIVY-12667 Spelling error
XIVY-12667 Changed process to match name for key generation
ivy-rew
reviewed
Nov 2, 2023
Comment on lines
1
to
13
| Variables: | ||
| threemaConnector: | ||
|
|
||
| # Your Threema.Gateway ID | ||
| threemaId: '' | ||
|
|
||
| # Your Threema.Gateway Secret | ||
| # [password] | ||
| secret: '' | ||
|
|
||
| # Your private key associated with your Threema.Gateway ID | ||
| # [password] | ||
| privateKey: '' |
ivy-rew
reviewed
Nov 2, 2023
| @@ -21,7 +23,7 @@ public class MessageSingleRecipientTest { | |||
| @Test | |||
| @Disabled | |||
| public void sendMessage() { | |||
There was a problem hiding this comment.
if you like to go an extra mile; we can now remove the @disabled ... and implement this test easily with the new 'WebAppFixture' that Lukas introduced last week
ivy-fhe
force-pushed
the
feature/XIVY-12667_ui
branch
from
f0165c0 to
79d0834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented feedback concerning the following topics: