Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/xivy 12667 optimization #4

Merged
merged 11 commits into from
Oct 26, 2023
Merged

Feature/xivy 12667 optimization #4

merged 11 commits into from
Oct 26, 2023

Conversation

ivy-fhe
Copy link
Contributor

@ivy-fhe ivy-fhe commented Oct 25, 2023

Implemented feedback:

  • Removed dropin installer
  • Added maven build step to delete zip-archive
  • Added simple process to generate Key-Pair
  • Updated README.md to reflect new process

@ivy-fhe ivy-fhe requested a review from ivy-rew October 25, 2023 15:10
@ivy-fhe ivy-fhe self-assigned this Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

Test Results

17 tests  +1   15 ✔️ +1   31s ⏱️ -1s
  9 suites +1     2 💤 ±0 
  9 files   +1     0 ❌ ±0 

Results for commit edad32d. ± Comparison against base commit f71d874.

♻️ This comment has been updated with latest results.

ivy-rew
ivy-rew reviewed Oct 26, 2023
View reviewed changes
threema-connector/pom.xml Outdated Show resolved Hide resolved
@ivy-rew
Copy link
Member

ivy-rew commented Oct 26, 2023 •
edited
Loading

some minor comments; you are free to choose whether you want to apply anyone of em.

can't wait to get my threema credits to actually run this stuff 👯

ivy-rew
ivy-rew approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@ivy-rew ivy-rew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ivy-fhe ivy-fhe merged commit b9b9e04 into master Oct 26, 2023
3 checks passed
@ivy-fhe ivy-fhe deleted the feature/XIVY-12667_optimization branch October 26, 2023 06:58
ivy-fhe added a commit that referenced this pull request Nov 2, 2023
@ivy-fhe
Merge pull request #4 from axonivy-market/feature/XIVY-12667_optimiza…
4de40c4 
…tion

Feature/xivy 12667 optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivy-rew ivy-rew ivy-rew approved these changes

Assignees

@ivy-fhe ivy-fhe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivy-fhe @ivy-rew