Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARP-1481 Upgrade for Ivy 12 #25

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

quanpham-axonivy
Copy link
Contributor

No description provided.

@quanpham-axonivy quanpham-axonivy self-assigned this Dec 3, 2024
@github-actions github-actions bot added the enhancement New feature or request label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

17 tests  ±0   17 ✅ ±0   41s ⏱️ -5s
 9 suites ±0    0 💤 ±0 
 9 files   ±0    0 ❌ ±0 

Results for commit 65f9462. ± Comparison against base commit 35d65dd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@nqhoan-axonivy nqhoan-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still in v10 for connector

@nqhoan-axonivy
Copy link
Contributor

Hi @quanpham-axonivy did you check it carefully, still 4 errors in the code. Please open Project Faces and adapt the setting
image

@quanpham-axonivy quanpham-axonivy force-pushed the feature/upgrade-for-ivy-12 branch from 808bda8 to 65f9462 Compare December 4, 2024 02:10
Copy link
Contributor

@nqhoan-axonivy nqhoan-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quanpham-axonivy quanpham-axonivy merged commit e6422c1 into master Dec 4, 2024
7 checks passed
@quanpham-axonivy quanpham-axonivy deleted the feature/upgrade-for-ivy-12 branch December 4, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants