Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XIVY-12055 Moved Mock-API to demo-project and updated Readme #7

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

ivy-edp
Copy link
Member

@ivy-edp ivy-edp commented Aug 25, 2023

No description provided.

@ivy-edp ivy-edp requested a review from ivy-lli August 25, 2023 07:02
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

Test Results

3 tests  +2   3 ✔️ +2   50s ⏱️ +36s
2 suites +1   0 💤 ±0 
2 files   +1   0 ±0 

Results for commit 38432bf. ± Comparison against base commit c06f2af.

♻️ This comment has been updated with latest results.

@ivy-lli
Copy link
Member

ivy-lli commented Aug 25, 2023

Seems that a test is still failing?

Copy link
Member

@ivy-lli ivy-lli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
Some small thing to revert :)

.project Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe revert this change too?

@@ -10,8 +10,7 @@
"name" : "setMockConfig.ivp",
"config" : {
"callSignature" : "setMockConfig",
"outLink" : "setMockConfig.ivp",
"showInStartList" : false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this

@@ -44,8 +43,7 @@
"name" : "cleanupMockConfig.ivp",
"config" : {
"callSignature" : "cleanupMockConfig",
"outLink" : "cleanupMockConfig.ivp",
"showInStartList" : false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this

@ivy-edp ivy-edp merged commit f7253d1 into master Sep 4, 2023
4 checks passed
@ivy-edp ivy-edp deleted the srf-weather-connector-mock branch September 4, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants