Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XIVY-12055 Completed Implementation: SRF Weather Connector, Demo Project, Process Test, WebTest and Product Descriptions #3

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

ivy-edp
Copy link
Member

@ivy-edp ivy-edp commented Aug 21, 2023

No description provided.

@alexsuter
Copy link
Member

can be reviewed by Lukas :). I will review the connector of Giger.

README.md Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
srf-weather-connector-WebTest/config/custom-fields.yaml Outdated Show resolved Hide resolved
srf-weather-connector-WebTest/pom.xml Outdated Show resolved Hide resolved
srf-weather-connector/processes/srfWeatherForecast.p.json Outdated Show resolved Hide resolved
srf-weather-connector/processes/srfWeatherForecast.p.json Outdated Show resolved Hide resolved
srf-weather-connector/webContent/icons/sun(1).jpg Outdated Show resolved Hide resolved
srf-weather-connector/webContent/icons/sunrise.png Outdated Show resolved Hide resolved
srf-weather-connector/webContent/layouts/basic-10.xhtml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

Test Results

1 tests   - 1   1 ✔️ ±0   20s ⏱️ +6s
1 suites ±0   0 💤  - 1 
1 files   ±0   0 ±0 

Results for commit f01653f. ± Comparison against base commit 0113b13.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
com.axonivy.connector.srf.weather.test.SampleProcessTest ‑ callProcess(BpmClient)
com.axonivy.connector.srf.weather.test.SampleProcessTest ‑ workflow(BpmClient)
com.axonivy.connector.srf.weather.test.TestSrfWeatherForecast ‑ locationAndWeatherOfZip(BpmClient)

♻️ This comment has been updated with latest results.

@ivy-edp ivy-edp requested a review from ivy-lli August 22, 2023 07:48
Copy link
Member

@ivy-lli ivy-lli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Thanks for the improvements

@ivy-edp ivy-edp merged commit 4db5f80 into master Aug 22, 2023
4 checks passed
@ivy-edp ivy-edp deleted the dev_weatherConnector branch August 22, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants