Feature/marp 1018 new connector rtf factory #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Total -- 36.96kb -> 21.36kb (42.21%) /rtf-factory-product/images/GeneratedDocument.png -- 11.73kb -> 4.80kb (59.11%) /rtf-factory-product/images/DemoDialog.png -- 25.23kb -> 16.56kb (34.35%) Signed-off-by: ImgBotApp <[email protected]>
…e-drafter-workflow MARP-620 Add release-drafter workflow
[ImgBot] Optimize images
tvtphuc-axonivy
commented
Sep 9, 2024
There was a problem hiding this comment.
Hi @ivy-bb , I have reset the master branch to your initial commit. I cloned your code to the branch "feature/MARP-1018-New-connector-RTF-Factory"
and then created a PR to the master branch that has some feedback needed to be addressed.
|
|
||
| public class ExportFromCms { | ||
|
|
||
| public static java.io.File export(String cmsUri, String ext) throws IOException { |
There was a problem hiding this comment.
-
Missing unit test for this method.
-
When I click "Create welcome document" . I see the "customer.name = Flury!" . The "." symbol is valid here ?
There was a problem hiding this comment.
I have improved the included cms text.
tvtphuc-axonivy
commented
Sep 9, 2024
rtf-factory-demo/src_hd/rtf/factory/demo/DemoDialog/DemoDialog.xhtml
Outdated
Show resolved
Hide resolved
|
Thank you very much for your good work. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.